Skip to content

Clear stored data when deleting accounts #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −1
Open

Clear stored data when deleting accounts #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed0cc9e
Clear preferences when deleting account
maxschwinghammer Aug 22, 2025
527bd5f
Update app/src/main/java/com/freshkeeper/service/account/AccountServi…
maxschwinghammer Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion app/src/main/java/com/freshkeeper/service/account/AccountServiceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,26 @@ class AccountServiceImpl
.await()

currentUser?.delete()?.await()
auth.signOut()

context
.getSharedPreferences("user_preferences", Context.MODE_PRIVATE)
.edit {
clear()
}

context
.getSharedPreferences(USER_PREFERENCES_KEY, Context.MODE_PRIVATE)
.edit {
clear()
}

context
.getSharedPreferences(FRESH_KEEPER_PREFS_KEY, Context.MODE_PRIVATE)
.edit {
clear()
}

Copy link

Copilot AI Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The preference clearing logic is duplicated for both shared preferences. Consider extracting this into a helper method that accepts the preference name as a parameter to reduce code duplication.

Suggested change
clearPreferences("user_preferences")
clearPreferences("FreshKeeperPrefs")

Copilot uses AI. Check for mistakes.
signOut()
}
} catch (e: FirebaseAuthRecentLoginRequiredException) {
Log.e("AccountServiceImpl", "User needs to reauthenticate", e)
Expand Down
Loading