Fix deprecated Gradle syntax and configuration features (#3358)

When running `./gradlew shadowJar compileTestJava --warning-mode=all` on
the current HEAD of `main` (68f805a), a number of warnings are
produced for deprecated usages of Gradle configuration features. Upon
fixing the trivial deprecations produced in the first pass, a second
round of issues is also produced. This pull request fixes all of those,
such that the command executes cleanly, without generating a Gradle
problem report.

Each class of issue is addressed in a separate commit (which contains
links to the Gradle documentation showing the fix mechanism to be the
recommended approach), but broadly speaking there are five categories:

1. Use of `destination` instead of `outputLocation` when configuring
JUnit report output location
([docs](https://docs.gradle.org/8.13/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:destination))
2. Consistent use of `key = value` assignment rather than "space
assignment" or `propertyName(value)` assignment
([docs](https://docs.gradle.org/8.13/userguide/upgrading_version_8.html#groovy_space_assignment_syntax))
3. Use of plugin blocks instead of conventions for the `Java` plugin
([docs](https://docs.gradle.org/8.13/userguide/upgrading_version_8.html#java_convention_deprecation))
4. Use of plugin blocks instead of conventions for the `Application`
plugin
([docs](https://docs.gradle.org/8.13/userguide/upgrading_version_8.html#application_convention_deprecation))
and applying the ensuing required cleanup from the Gradle 7 migration
([docs](https://docs.gradle.org/current/userguide/upgrading_version_7.html#javaapplication_api_cleanup))
5. Stopping the use of `Task.project` in Task actions
([docs](https://docs.gradle.org/8.13/userguide/upgrading_version_7.html#task_project)).

Other tasks which are not dependents of `shadowJar` or `compileTestJava`
likely still use deprecated syntax or conventions - I will follow up
with a second pull request to address those in future.

Author: jen20

build.gradle

@@ -100,19 +100,22 @@ allprojects {
 
     // Configure JUnit tests
     tasks.withType(Test) {
-        reports.junitXml.destination = project.file("${->project.buildDir}/test-results")
+        reports.junitXml.outputLocation = project.file("${->project.buildDir}/test-results")
     }
 
+    def projectName = it.name
+    def projectVersion = it.version
+
     // Configure JAR generation
     tasks.jar.configure {
         description = "Produces a Jar with the main classes in .out/."
         manifest {
             attributes "Built-JDK": System.getProperty("java.version"),
-                    "Specification-Title": project.name,
-                    "Specification-Version": "${-> project.version}",
+                    "Specification-Title": projectName,
+                    "Specification-Version": "${-> projectVersion}",
                     "Specification-Vendor": "Apple Inc.",
-                    "Implementation-Title": project.name,
-                    "Implementation-Version": "${-> project.version}",
+                    "Implementation-Title": projectName,
+                    "Implementation-Version": "${-> projectVersion}",
                     "Implementation-Vendor": "Apple Inc."
         }
         doFirst {
@@ -182,8 +185,10 @@ allprojects {
 subprojects {
     apply from: rootProject.file('gradle/testing.gradle')
 
-    sourceCompatibility = JavaVersion.VERSION_11
-    targetCompatibility = JavaVersion.VERSION_11
+    java {
+        sourceCompatibility = JavaVersion.VERSION_11
+        targetCompatibility = JavaVersion.VERSION_11
+    }
 
     def publishBuild = Boolean.parseBoolean(findProperty('publishBuild') ?: 'false')
     def autoServiceVersion = publishBuild ? libs.versions.autoService.asProvider().get() : libs.versions.autoService.development.get()

examples/examples.gradle

@@ -30,5 +30,7 @@ dependencies {
     runtimeOnly(libs.log4j.core) // library
 }
 
-mainClassName = 'com.apple.foundationdb.record.sample.Main'
-applicationDefaultJvmArgs = ["-Dlog4j.configurationFile=${projectDir}/src/main/resources/log4j2.properties"]
+application {
+    mainClass = 'com.apple.foundationdb.record.sample.Main'
+    applicationDefaultJvmArgs = ["-Dlog4j.configurationFile=${projectDir}/src/main/resources/log4j2.properties"]
+}

fdb-relational-api/fdb-relational-api.gradle

@@ -30,16 +30,19 @@ task createVersionPropertiesFile()  {
     // Write a file of version and build info for the java processes to read
     // from their classpaths.
     def versionsFile = new File(projectDir, "src/gen/main/resources/version.properties")
+    def projectVersion = project.version
+    def rootProjectName = rootProject.name
     def gitDetails = versionDetails()
+
     outputs.file versionsFile
     doLast {
         println "Writing ${versionsFile}"
         versionsFile.text = """# Generated by fdb-relational-api build.
 # Returned by RelationalDatabaseMetaData#getDatabaseProductName()
-name=${rootProject.name}
+name=${rootProjectName}
 # Returned by RelationalDatabaseMetaData#getDatabaseProductVersion()
 # and by RelationalDatabaseMetaData#getDriverVersion()
-version=${project.version}
+version=${projectVersion}
 gitHash=${gitDetails.gitHashFull}
 branch=${gitDetails.branchName}
 # Returned as RelationalDatabaseMetaData#getUrl()

fdb-relational-cli/fdb-relational-cli.gradle

@@ -74,7 +74,7 @@ dependencies {
 }
 
 jar {
-    duplicatesStrategy "exclude"
+    duplicatesStrategy = "exclude"
     manifest {
         attributes(
                 'Main-Class': 'com.apple.foundationdb.relational.cli.sqlline.RelationalSQLLine',

fdb-relational-jdbc/fdb-relational-jdbc.gradle

@@ -52,7 +52,7 @@ serviceLoader {
 }
 
 jar {
-    duplicatesStrategy "exclude"
+    duplicatesStrategy = "exclude"
 }
 
 // Task to build a fat jar, one w/ all dependencies; good for handing out as the 'jdbc' jar.

fdb-relational-server/fdb-relational-server.gradle

@@ -56,7 +56,9 @@ jar {
 
 // Task to build a fat jar, one w/ all dependencies
 shadowJar {
-    mainClassName = mainServerClass
+    application {
+        mainClass = mainServerClass
+    }
     mergeServiceFiles()
 }
 

gradle/testing.gradle

@@ -40,7 +40,7 @@ task destructiveTest(type: Test) {
         maxParallelForks = 1
     }
     reports {
-        junitXml.destination = file("${buildDir}/test-results/destructive")
+        junitXml.outputLocation = file("${buildDir}/test-results/destructive")
     }
 }
 

yaml-tests/yaml-tests.gradle

@@ -33,7 +33,7 @@ project.tasks.named("processTestResources") {
 }
 
 tasks.named("sourcesJar") {
-    duplicatesStrategy('include')
+    duplicatesStrategy = 'include'
     // classifier('sources')
     from sourceSets.main.allSource
 }