Fix some software rot in the sqlline CLI: (#3502)

* The wrapper script expects the generated script to have the same name,
so rename it to match.
* The Main class name has changed somewhere along the line.
* The log4j XML(!) config file didn't have valid syntax (? directive
needs to be at the front)
* Upgrade jline to after jline/jline3#688,
which turned off JNA, which was crashing on ARM Mac.
* Make the convenience launcher go through the class that registers the
driver

Author: MMcM

fdb-relational-cli/bin/sqlline renamed to fdb-relational-cli/bin/fdb-relational-sqlline

@@ -108,7 +108,7 @@ generateGrammarSource {
 application {
     // https://docs.gradle.org/current/userguide/application_plugin.html
     // https://github.com/julianhyde/sqlline
-    mainClass = "com.apple.relational.cli.sqlline.RelationalSQLLine"
+    mainClass = "com.apple.foundationdb.relational.cli.sqlline.RelationalSQLLine"
     applicationName = "fdb-relational-sqlline"
     // JUL => log4j2 https://logging.apache.org/log4j/2.x/log4j-jul/index.html
     // TODO: Allow overriding default fdb.cluster file with FDB_CLUSTER_FILE.

fdb-relational-cli/fdb-relational-cli.gradle

@@ -1,3 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
 <!--
  log4j2.xml
 
@@ -18,7 +19,6 @@
  limitations under the License.
 -->
 
-<?xml version="1.0" encoding="UTF-8"?>
 <Configuration status="INFO">
     <Appenders>
         <Console name="Console" target="SYSTEM_OUT">

fdb-relational-cli/src/main/dist/conf/log4j2.xml

@@ -22,8 +22,6 @@
 
 import com.apple.foundationdb.relational.util.ExcludeFromJacocoGeneratedReport;
 
-import java.io.IOException;
-
 /**
  * Convenience class for launching sqlline so can run it under the debugger.
  * Be aware that the intellij terminal is dodgy. See
@@ -32,10 +30,9 @@
  */
 @ExcludeFromJacocoGeneratedReport // Test utility only.
 public class LaunchSQLLine {
-    public static void main(String[] args/*Ignored*/) throws IOException {
+    public static void main(String[] args/*Ignored*/) throws Exception {
         // Read [SQLLINE-80] to see why maxWidth must be set
-        sqlline.SqlLine.main(new String []{
-                "-ac", "com.apple.foundationdb.relational.cli.sqlline.Customize",
+        com.apple.foundationdb.relational.cli.sqlline.RelationalSQLLine.main(new String []{
                 "-u", "jdbc:embed:/__SYS",
                 "--maxWidth=160",
         });

fdb-relational-cli/src/test/java/com/apple/foundationdb/relational/cli/LaunchSQLLine.java

@@ -61,7 +61,7 @@ bndtools = "6.3.1"
 diffutils = "4.12"
 hamcrest = "2.2"
 jcommander = "1.81"
-jline = "3.19.0"
+jline = "3.30.4"
 junit = "5.11.3"
 junit-platform = "1.7.1"
 mockito = "3.7.7"