catch IndexOutOfBoundsException when accessing fields from metadata (#3672)

Accessing fields in struct metadata that are actually out of range, used
to throw the underlying exception without actually wrapping it into
SQLException, as required by the API. This was intrduced by a previous
PR that changed the struct and arrays metadata to be backed by
Relational's DataType rather than relying on sql type codes. This PR
fixes this.

Author: g31pranjal

fdb-relational-api/src/main/java/com/apple/foundationdb/relational/api/RelationalStructMetaData.java

@@ -165,7 +165,7 @@ private DataType.StructType.Field getField(int oneBasedColumn) throws SQLExcepti
         try {
             int adjustedColPosition = leadingPhantomColumnOffset + (oneBasedColumn - 1);
             return type.getFields().get(adjustedColPosition);
-        } catch (ArrayIndexOutOfBoundsException aie) {
+        } catch (IndexOutOfBoundsException exception) {
             throw new InvalidColumnReferenceException("Position <" + oneBasedColumn + "> is not valid. Struct has " + getColumnCount() + " columns")
                     .toSqlException();
         }

fdb-relational-core/src/test/java/com/apple/foundationdb/relational/recordlayer/StructDataMetadataTest.java

@@ -26,9 +26,7 @@
 import com.apple.foundationdb.relational.api.Options;
 import com.apple.foundationdb.relational.api.RelationalResultSet;
 import com.apple.foundationdb.relational.api.RelationalStruct;
-import com.apple.foundationdb.relational.api.exceptions.RelationalException;
 import com.apple.foundationdb.relational.utils.SimpleDatabaseRule;
-
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Order;
@@ -40,6 +38,8 @@
 import java.sql.SQLException;
 import java.util.Set;
 
+import static com.apple.foundationdb.relational.utils.RelationalAssertions.assertThrowsSqlException;
+
 /**
  * Tests around using Struct data types in Returned ResultSets.
  */
@@ -77,24 +77,21 @@ public class StructDataMetadataTest {
 
     @BeforeEach
     void setUp() throws SQLException {
-        final var t1 = EmbeddedRelationalStruct.newBuilder();
-        var m = t1.addString("NAME", "test_record_1")
+        var m = EmbeddedRelationalStruct.newBuilder()
+                .addString("NAME", "test_record_1")
                 .addStruct("ST1", EmbeddedRelationalStruct.newBuilder().addString("A", "Hello").build())
                 .build();
-
         statement.executeInsert("T", m);
 
-        final var ntBuilder = EmbeddedRelationalStruct.newBuilder();
-        final var stBuilder = EmbeddedRelationalStruct.newBuilder();
-        m = ntBuilder.addString("T_NAME", "nt_record")
-                .addStruct("ST1", stBuilder
+        m = EmbeddedRelationalStruct.newBuilder()
+                .addString("T_NAME", "nt_record")
+                .addStruct("ST1", EmbeddedRelationalStruct.newBuilder()
                         .addLong("C", 1234L)
                         .addStruct("D", EmbeddedRelationalStruct.newBuilder()
                                 .addString("A", "Goodbye")
                                 .build())
                         .build())
                 .build();
-
         statement.executeInsert("NT", m);
 
         final var atBuilder = EmbeddedRelationalStruct.newBuilder();
@@ -110,9 +107,7 @@ void setUp() throws SQLException {
                                 .build())
                         .build())
                 .build();
-
         statement.executeInsert("AT", m);
-
     }
 
     @Test
@@ -130,6 +125,19 @@ void canReadSingleStruct() throws Exception {
         }
     }
 
+    @Test
+    void errorAccessingNonExistentColumn() throws Exception {
+        try (final RelationalResultSet resultSet = statement.executeGet("T", new KeySet().setKeyColumn("NAME", "test_record_1"), Options.NONE)) {
+            Assertions.assertTrue(resultSet.next(), "Did not find a record!");
+            final var actualStruct = resultSet.getStruct("ST1");
+            Assertions.assertNotNull(actualStruct, "No struct found for column!");
+            // Directly accessing the value throws SQLException
+            assertThrowsSqlException(() -> actualStruct.getString(100)).containsInMessage("Invalid column position");
+            // Accessing info in metadata throws SQLException as well
+            assertThrowsSqlException(() -> actualStruct.getMetaData().getColumnType(100)).containsInMessage("Position <100> is not valid.");
+        }
+    }
+
     @Test
     void canReadNestedStruct() throws Exception {
         final KeySet key = new KeySet().setKeyColumn("T_NAME", "nt_record");
@@ -190,7 +198,7 @@ void canReadRepeatedStruct() throws Exception {
     }
 
     @Test
-    void canReadRepeatedStructWithArray() throws RelationalException, SQLException {
+    void canReadRepeatedStructWithArray() throws SQLException {
         final KeySet key = new KeySet().setKeyColumn("A_NAME", "a_test_rec");
         try (final RelationalResultSet resultSet = statement.executeGet("AT", key, Options.NONE)) {
             Assertions.assertTrue(resultSet.next(), "Did not find a record!");