deprecate weight keyword arg in Conv constructor

Author: CarloLucibello

NEWS.md

@@ -6,6 +6,7 @@
 been removed in favour of MLDatasets.jl.
 * `params` is not exported anymore since it is a common name and is also exported by Distributions.jl 
 * `flatten` is not exported anymore due to clash with Iterators.flatten.
+* Remove Juno.jl progress bar support as it is now obsolete.
 
 ## v0.12.9
 * Fixed incorrect output and added GPU compatibility for [AlphaDropout](https://github.com/FluxML/Flux.jl/pull/1781).

Project.toml

@@ -7,7 +7,6 @@ Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
 CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
 Functors = "d9f16b24-f501-4c13-a1f2-28368ffc5196"
-Juno = "e5e0dc1b-0480-54bc-9374-aad01c23163d"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"
 NNlib = "872c559c-99b0-510c-b3b7-b6c96a88d5cd"
@@ -25,7 +24,6 @@ Adapt = "3.0"
 ArrayInterface = "3.1"
 CUDA = "3"
 Functors = "0.2.1"
-Juno = "0.8"
 MacroTools = "0.5"
 NNlib = "0.7.24"
 NNlibCUDA = "0.1.7"

docs/src/models/basics.md

@@ -35,9 +35,9 @@ These gradients are based on `x` and `y`. Flux works by instead taking gradients
 Machine learning often can have *hundreds* of parameters, so Flux lets you work with collections of parameters, via the `params` functions. You can get the gradient of all parameters used in a program without explicitly passing them in.
 
 ```jldoctest basics
-julia> x = [1, 2];
+julia> x = [2, 1];
 
-julia> y = [3, 5];
+julia> y = [2, 0];
 
 julia> gs = gradient(Flux.params(x, y)) do
          f(x, y)

src/layers/conv.jl

@@ -136,8 +136,13 @@ end
 
 function Conv(k::NTuple{N,Integer}, ch::Pair{<:Integer,<:Integer}, σ = identity;
             init = glorot_uniform, stride = 1, pad = 0, dilation = 1, groups = 1,
-            weight = convfilter(k, ch; init, groups), bias = true) where N
-
+            weight = nothing, bias = true) where N
+    if weight !== nothing
+      # TODO remove in v0.14
+      Base.depwarn("The `weight` keyword arg is deprecated, use the Conv(weight, ...) constructor instead", :conv_weight)
+    else
+      weight = convfilter(k, ch; init, groups)
+    end
   Conv(weight, bias, σ; stride, pad, dilation, groups)
 end
 

src/optimise/train.jl

@@ -1,4 +1,3 @@
-using Juno
 import Zygote: Params, gradient
 
 """
@@ -139,7 +138,7 @@ hello
 ```
 """
 macro epochs(n, ex)
-  :(@progress for i = 1:$(esc(n))
+  :(for i = 1:$(esc(n))
       @info "Epoch $i"
       $(esc(ex))
     end)