chore: refactor rule definition to only use advanced rule others

junners · junners · commit 2f3de1f116e5 · 2025-08-02T08:21:53.000-07:00
diff --git a/src/main/rules/HardcodedUrl.ts b/src/main/rules/HardcodedUrl.ts
@@ -1,7 +1,7 @@
-import { Flow, FlowType, IRuleDefinition, ResultDetails, RuleResult } from "../internals/internals";
+import { Flow, FlowType, ResultDetails, RuleResult } from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class HardcodedUrl extends AdvancedRule implements IRuleDefinition {
+export class HardcodedUrl extends AdvancedRule {
   constructor() {
     super(
       {
diff --git a/src/main/rules/InactiveFlow.ts b/src/main/rules/InactiveFlow.ts
@@ -1,17 +1,17 @@
-import { AdvancedRule } from "../models/AdvancedRule";
 import * as core from "../internals/internals";
+import { AdvancedRule } from "../models/AdvancedRule";
 
-export class InactiveFlow extends AdvancedRule implements core.IRuleDefinition {
+export class InactiveFlow extends AdvancedRule {
   constructor() {
     super({
-      name: "InactiveFlow",
-      label: "Inactive Flow",
+      autoFixable: false,
       description:
         "Like cleaning out your closet: deleting unused flows is essential. Inactive flows can still cause trouble, like accidentally deleting records during testing, or being activated as subflows within parent flows.",
-      supportedTypes: core.FlowType.allTypes(),
       docRefs: [],
       isConfigurable: false,
-      autoFixable: false, // TODO: make fixable
+      label: "Inactive Flow",
+      name: "InactiveFlow",
+      supportedTypes: core.FlowType.allTypes(),
     });
   }
 
diff --git a/src/main/rules/MissingFaultPath.ts b/src/main/rules/MissingFaultPath.ts
@@ -3,10 +3,7 @@ import { AdvancedSuppression } from "../interfaces/AdvancedSuppression";
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class MissingFaultPath
-  extends AdvancedRule
-  implements AdvancedSuppression, core.IRuleDefinition
-{
+export class MissingFaultPath extends AdvancedRule implements AdvancedSuppression {
   protected applicableElements: string[] = [
     "recordLookups",
     "recordDeletes",
diff --git a/src/main/rules/MissingNullHandler.ts b/src/main/rules/MissingNullHandler.ts
@@ -1,7 +1,7 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class MissingNullHandler extends AdvancedRule implements core.IRuleDefinition {
+export class MissingNullHandler extends AdvancedRule {
   constructor() {
     super({
       autoFixable: false,
@@ -15,6 +15,7 @@ export class MissingNullHandler extends AdvancedRule implements core.IRuleDefini
     });
   }
 
+  // eslint-disable-next-line sonarjs/cognitive-complexity
   public execute(flow: core.Flow): core.RuleResult {
     const getOperations = ["recordLookups"];
     const getOperationElements: core.FlowNode[] = flow.elements.filter(
@@ -45,8 +46,8 @@ export class MissingNullHandler extends AdvancedRule implements core.IRuleDefini
       const resultIsUsed = flow.elements.some((el) => {
         if (el.name === getElement.name) return false;
         const json = JSON.stringify(el.element);
-        return resultReferences.some((ref) =>
-          json.includes(`"${ref}"`) || json.includes(`"${ref}.`)
+        return resultReferences.some(
+          (ref) => json.includes(`"${ref}"`) || json.includes(`"${ref}.`)
         );
       });
       if (!resultIsUsed) continue;
diff --git a/src/main/rules/ProcessBuilder.ts b/src/main/rules/ProcessBuilder.ts
@@ -1,22 +1,22 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class ProcessBuilder extends AdvancedRule implements core.IRuleDefinition {
+export class ProcessBuilder extends AdvancedRule {
   constructor() {
     super({
-      name: "ProcessBuilder",
-      label: "No Process Builder",
+      autoFixable: false,
       description:
         "Salesforce is transitioning away from Workflow Rules and Process Builder in favor of Flow. Ensure you're prepared for this transition by migrating your organization's automation to Flow. Refer to official documentation for more information on the transition process and tools available.",
-      supportedTypes: core.FlowType.processBuilder,
       docRefs: [
         {
           label: "Process Builder Retirement",
           path: "https://help.salesforce.com/s/articleView?id=000389396&type=1",
         },
       ],
       isConfigurable: true,
-      autoFixable: false,
+      label: "No Process Builder",
+      name: "ProcessBuilder",
+      supportedTypes: core.FlowType.processBuilder,
     });
   }
 
diff --git a/src/main/rules/RecursiveAfterUpdate.ts b/src/main/rules/RecursiveAfterUpdate.ts
@@ -1,7 +1,7 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class RecursiveAfterUpdate extends AdvancedRule implements core.IRuleDefinition {
+export class RecursiveAfterUpdate extends AdvancedRule {
   protected qualifiedRecordTriggerTypes: Set<string> = new Set<string>([
     "Create",
     "CreateAndUpdate",
diff --git a/src/main/rules/SOQLQueryInLoop.ts b/src/main/rules/SOQLQueryInLoop.ts
@@ -1,7 +1,7 @@
-import { FlowType, IRuleDefinition } from "../internals/internals";
+import { FlowType } from "../internals/internals";
 import { LoopRuleCommon } from "../models/LoopRuleCommon";
 
-export class SOQLQueryInLoop extends LoopRuleCommon implements IRuleDefinition {
+export class SOQLQueryInLoop extends LoopRuleCommon {
   constructor() {
     super({
       autoFixable: false,
diff --git a/src/main/rules/SameRecordFieldUpdates.ts b/src/main/rules/SameRecordFieldUpdates.ts
@@ -1,29 +1,29 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class SameRecordFieldUpdates extends AdvancedRule implements core.IRuleDefinition {
+export class SameRecordFieldUpdates extends AdvancedRule {
   protected qualifiedRecordTriggerTypes: Set<string> = new Set<string>([
     "Create",
-    "Update",
     "CreateAndUpdate",
+    "Update",
   ]);
 
   constructor() {
     super(
       {
-        name: "SameRecordFieldUpdates",
-        label: "Same Record Field Updates",
+        autoFixable: false,
         description:
           "Before-save same-record field updates allows you to update the record using variable assignments to `$Record`. This is significantly faster than doing another DML on the same-record that triggered the flow",
-        supportedTypes: [...core.FlowType.backEndTypes],
         docRefs: [
           {
             label: "Learn about same record field updates",
             path: "https://architect.salesforce.com/decision-guides/trigger-automation#Same_Record_Field_Updates",
           },
         ],
         isConfigurable: false,
-        autoFixable: false,
+        label: "Same Record Field Updates",
+        name: "SameRecordFieldUpdates",
+        supportedTypes: [...core.FlowType.backEndTypes],
       },
       { severity: "warning" }
     );
diff --git a/src/main/rules/TriggerOrder.ts b/src/main/rules/TriggerOrder.ts
@@ -1,25 +1,25 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class TriggerOrder extends AdvancedRule implements core.IRuleDefinition {
+export class TriggerOrder extends AdvancedRule {
   protected qualifiedRecordTriggerTypes: Set<string> = new Set<string>(["Create", "Update"]);
 
   constructor() {
     super(
       {
-        name: "TriggerOrder",
-        label: "Trigger Order",
+        autoFixable: false,
         description:
           "With flow trigger ordering, introduced in Spring '22, admins can now assign a priority value to their flows and guarantee their execution order. This priority value is not an absolute value, so the values need not be sequentially numbered as 1, 2, 3, and so on.",
-        supportedTypes: [core.FlowType.autolaunchedType],
         docRefs: [
           {
             label: "Learn more about flow ordering orchestration",
             path: "https://architect.salesforce.com/decision-guides/trigger-automation#Ordering___Orchestration",
           },
         ],
         isConfigurable: false,
-        autoFixable: false,
+        label: "Trigger Order",
+        name: "TriggerOrder",
+        supportedTypes: [core.FlowType.autolaunchedType],
       },
       { severity: "note" }
     );
diff --git a/src/main/rules/UnconnectedElement.ts b/src/main/rules/UnconnectedElement.ts
@@ -1,7 +1,7 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class UnconnectedElement extends AdvancedRule implements core.IRuleDefinition {
+export class UnconnectedElement extends AdvancedRule {
   constructor() {
     super({
       autoFixable: true,
diff --git a/src/main/rules/UnsafeRunningContext.ts b/src/main/rules/UnsafeRunningContext.ts
@@ -1,14 +1,12 @@
 import * as core from "../internals/internals";
 import { AdvancedRule } from "../models/AdvancedRule";
 
-export class UnsafeRunningContext extends AdvancedRule implements core.IRuleDefinition {
+export class UnsafeRunningContext extends AdvancedRule {
   constructor() {
     super(
       {
-        name: "UnsafeRunningContext",
-        label: "Unsafe Running Context",
+        autoFixable: false,
         description: `This flow is configured to run in System Mode without Sharing. This system context grants all running users the permission to view and edit all data in your org. Running a flow in System Mode without Sharing can lead to unsafe data access.`,
-        supportedTypes: [...core.FlowType.backEndTypes, ...core.FlowType.visualTypes],
         docRefs: [
           {
             label:
@@ -17,7 +15,9 @@ export class UnsafeRunningContext extends AdvancedRule implements core.IRuleDefi
           },
         ],
         isConfigurable: false,
-        autoFixable: false,
+        label: "Unsafe Running Context",
+        name: "UnsafeRunningContext",
+        supportedTypes: [...core.FlowType.backEndTypes, ...core.FlowType.visualTypes],
       },
       { severity: "warning" }
     );
diff --git a/src/main/rules/UnusedVariable.ts b/src/main/rules/UnusedVariable.ts
@@ -1,17 +1,17 @@
-import { AdvancedRule } from "../models/AdvancedRule";
 import * as core from "../internals/internals";
+import { AdvancedRule } from "../models/AdvancedRule";
 
-export class UnusedVariable extends AdvancedRule implements core.IRuleDefinition {
+export class UnusedVariable extends AdvancedRule {
   constructor() {
     super({
-      name: "UnusedVariable",
-      label: "Unused Variable",
+      autoFixable: true,
       description:
         "To maintain the efficiency and manageability of your Flow, it's advisable to avoid including unconnected variables that are not in use.",
-      supportedTypes: [...core.FlowType.backEndTypes, ...core.FlowType.visualTypes],
       docRefs: [],
       isConfigurable: false,
-      autoFixable: true,
+      label: "Unused Variable",
+      name: "UnusedVariable",
+      supportedTypes: [...core.FlowType.backEndTypes, ...core.FlowType.visualTypes],
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`		`-import { Flow, FlowType, IRuleDefinition, ResultDetails, RuleResult } from "../internals/internals";`
	`1`	`+import { Flow, FlowType, ResultDetails, RuleResult } from "../internals/internals";`
`2`	`2`	`import { AdvancedRule } from "../models/AdvancedRule";`
`3`	`3`
`4`		`-export class HardcodedUrl extends AdvancedRule implements IRuleDefinition {`
	`4`	`+export class HardcodedUrl extends AdvancedRule {`
`5`	`5`	`constructor() {`
`6`	`6`	`super(`
`7`	`7`	`{`