Refactor save settings logic

SettingWindowViewModel.Save() only saves Flow settings

Author: VictoriousRaptor

Flow.Launcher.Core/Plugin/PluginManager.cs

@@ -48,6 +48,9 @@ private static void DeletePythonBinding()
             }
         }
 
+        /// <summary>
+        /// Save json and ISavable 
+        /// </summary>
         public static void Save()
         {
             foreach (var plugin in AllPlugins)

Flow.Launcher/PublicAPIInstance.cs

@@ -77,7 +77,7 @@ public void RestartApp()
 
         public void SaveAppAllSettings()
         {
-            SavePluginSettings();
+            PluginManager.Save();
             _mainVM.Save();
             _settingsVM.Save();
             ImageLoader.Save();
@@ -158,6 +158,9 @@ public void LogException(string className, string message, Exception e,
 
         private readonly ConcurrentDictionary<Type, object> _pluginJsonStorages = new();
 
+        /// <summary>
+        /// Save plugin settings.
+        /// </summary>
         public void SavePluginSettings()
         {
             foreach (var value in _pluginJsonStorages.Values)

Flow.Launcher/SettingWindow.xaml.cs

@@ -226,6 +226,7 @@ private void OnClosed(object sender, EventArgs e)
             settings.SettingWindowTop = Top;
             settings.SettingWindowLeft = Left;
             viewModel.Save();
+            API.SavePluginSettings();
         }
 
         private void OnCloseExecuted(object sender, ExecutedRoutedEventArgs e)

Flow.Launcher/ViewModel/SettingWindowViewModel.cs

@@ -133,6 +133,9 @@ public bool PortableMode
             }
         }
 
+        /// <summary>
+        /// Save Flow settings. Plugins settings are not included.
+        /// </summary>
         public void Save()
         {
             foreach (var vm in PluginViewModels)
@@ -143,7 +146,6 @@ public void Save()
                 Settings.PluginSettings.Plugins[id].Priority = vm.Priority;
             }
 
-            PluginManager.Save();
             _storage.Save();
         }