Skip to content

Commit a259d9c

Browse files
committed
Cleanup: remove comment about BOOLEAN
1 parent 52ed85d commit a259d9c

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

ibase_query.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,6 @@ static int _php_ibase_bind_array(zval *val, char *buf, zend_ulong buf_size, /* {
483483
convert_to_double(val);
484484
*(float*) buf = (float) Z_DVAL_P(val);
485485
break;
486-
// Boolean data type exists since FB 3.0
487486
#ifdef SQL_BOOLEAN
488487
case SQL_BOOLEAN:
489488
convert_to_boolean(val);
@@ -697,7 +696,6 @@ static int _php_ibase_bind(ibase_query *ib_query, zval *b_vars) /* {{{ */
697696
buf[i].val.qval = ib_blob.bl_qd;
698697
}
699698
continue;
700-
// Boolean data type exists since FB 3.0
701699
#ifdef SQL_BOOLEAN
702700
case SQL_BOOLEAN:
703701

@@ -815,7 +813,6 @@ static void _php_ibase_alloc_xsqlda_vars(XSQLDA *sqlda, ISC_SHORT *nullinds) /*
815813
case SQL_VARYING:
816814
var->sqldata = safe_emalloc(sizeof(char), var->sqllen + sizeof(short), 0);
817815
break;
818-
// Boolean data type exists since FB 3.0
819816
#ifdef SQL_BOOLEAN
820817
case SQL_BOOLEAN:
821818
var->sqldata = emalloc(sizeof(FB_BOOLEAN));
@@ -1312,7 +1309,6 @@ static int _php_ibase_var_zval(zval *val, void *data, int type, int len, /* {{{
13121309
case SQL_TEXT:
13131310
ZVAL_STRINGL(val, (char*)data, len);
13141311
break;
1315-
// Boolean data type exists since FB 3.0
13161312
#ifdef SQL_BOOLEAN
13171313
case SQL_BOOLEAN:
13181314
ZVAL_BOOL(val, *(FB_BOOLEAN *) data);
@@ -1322,6 +1318,7 @@ static int _php_ibase_var_zval(zval *val, void *data, int type, int len, /* {{{
13221318
n = *(short *) data;
13231319
goto _sql_long;
13241320
case SQL_INT64:
1321+
// TODO: do tests cover these cases?
13251322
#if (SIZEOF_ZEND_LONG >= 8)
13261323
n = *(zend_long *) data;
13271324
goto _sql_long;
@@ -1955,7 +1952,6 @@ static void _php_ibase_field_info(zval *return_value, ibase_query *ib_query, int
19551952
unsigned short precision = 0;
19561953

19571954
switch (var->sqltype & ~1) {
1958-
// Boolean data type exists since FB 3.0
19591955
#ifdef SQL_BOOLEAN
19601956
case SQL_BOOLEAN:
19611957
precision = 1;
@@ -1985,7 +1981,6 @@ static void _php_ibase_field_info(zval *return_value, ibase_query *ib_query, int
19851981
case SQL_SHORT:
19861982
s = "SMALLINT";
19871983
break;
1988-
// Boolean data type exists since FB 3.0
19891984
#ifdef SQL_BOOLEAN
19901985
case SQL_BOOLEAN:
19911986
s = "BOOLEAN";

php_ibase_includes.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ typedef struct event {
128128
*/
129129
typedef struct {
130130
union {
131-
// Boolean data type exists since FB 3.0
132131
#ifdef SQL_BOOLEAN
133132
FB_BOOLEAN bval;
134133
#endif

0 commit comments

Comments
 (0)