Added Boolean-Support. New Version 1.1.0-beta

Author: Martin Köditz

ibase_query.c

@@ -82,7 +82,7 @@ typedef struct {
  */
 typedef struct {
 	union {
-	    bool bval;
+	    zend_bool bval;
 		short sval;
 		float fval;
 		ISC_LONG lval;
@@ -244,7 +244,7 @@ static int _php_ibase_alloc_array(ibase_array **ib_arrayp, XSQLDA *sqlda, /* {{{
 					break;
                 case blr_bool:
                     a->el_type = SQL_BOOLEAN;
-                    a->el_size = sizeof(bool);
+                    a->el_size = sizeof(zend_bool);
                     break;
 				case blr_short:
 					a->el_type = SQL_SHORT;
@@ -582,8 +582,8 @@ static int _php_ibase_bind_array(zval *val, char *buf, zend_ulong buf_size, /* {
 					*(float*) buf = (float) Z_DVAL_P(val);
 					break;
                 case SQL_BOOLEAN:
-                    //convert_to_bool(val);
-                    *(bool*) buf = Z_DVAL_P(val);
+                    convert_to_boolean(val);
+                    *(zend_bool*) buf = Z_BVAL_P(val);
                     break;
 				case SQL_DOUBLE:
 					convert_to_double(val);
@@ -671,7 +671,6 @@ static int _php_ibase_bind(XSQLDA *sqlda, zval *b_vars, BIND_BUF *buf, /* {{{ */
 
 				/* for these types, an empty string can be handled like a NULL value */
 				switch (var->sqltype & ~1) {
-                    case SQL_BOOLEAN:
 					case SQL_SHORT:
 					case SQL_LONG:
 					case SQL_INT64:
@@ -773,6 +772,37 @@ static int _php_ibase_bind(XSQLDA *sqlda, zval *b_vars, BIND_BUF *buf, /* {{{ */
 				}
 				continue;
 
+            case SQL_BOOLEAN:
+
+                convert_to_string(b_var);
+                var->sqldata = Z_STRVAL_P(b_var);
+                var->sqllen	 = Z_STRLEN_P(b_var);
+                var->sqltype = SQL_BOOLEAN;
+                continue;
+
+				if (Z_STRLEN_P(b_var) != BLOB_ID_LEN ||
+					!_php_ibase_string_to_quad(Z_STRVAL_P(b_var), &buf[i].val.qval)) {
+
+					ibase_blob ib_blob = { 0, BLOB_INPUT };
+
+					if (isc_create_blob(IB_STATUS, &ib_query->link->handle,
+							&ib_query->trans->handle, &ib_blob.bl_handle, &ib_blob.bl_qd)) {
+						_php_ibase_error();
+						return FAILURE;
+					}
+
+					if (_php_ibase_blob_add(b_var, &ib_blob) != SUCCESS) {
+						return FAILURE;
+					}
+
+					if (isc_close_blob(IB_STATUS, &ib_blob.bl_handle)) {
+						_php_ibase_error();
+						return FAILURE;
+					}
+					buf[i].val.qval = ib_blob.bl_qd;
+				}
+				continue;
+
 			case SQL_ARRAY:
 
 				if (Z_TYPE_P(b_var) != IS_ARRAY) {
@@ -836,7 +866,7 @@ static void _php_ibase_alloc_xsqlda(XSQLDA *sqlda) /* {{{ */
 				var->sqldata = safe_emalloc(sizeof(char), var->sqllen + sizeof(short), 0);
 				break;
             case SQL_BOOLEAN:
-                var->sqldata = emalloc(sizeof(bool));
+                var->sqldata = emalloc(sizeof(zend_bool));
                 break;
 			case SQL_SHORT:
 				var->sqldata = emalloc(sizeof(short));
@@ -1338,11 +1368,9 @@ static int _php_ibase_var_zval(zval *val, void *data, int type, int len, /* {{{
 		case SQL_TEXT:
 			ZVAL_STRINGL(val, (char*)data, len);
 			break;
+		// The query's field value is boolean
         case SQL_BOOLEAN:
-            if(val)
-                ZVAL_BOOL(val,1);
-            else
-                ZVAL_BOOL(val,0);
+            ZVAL_BOOL(val, *(bool *) data);
             break;
 		case SQL_SHORT:
 			n = *(short *) data;
@@ -1931,6 +1959,10 @@ static void _php_ibase_field_info(zval *return_value, XSQLVAR *var) /* {{{ */
 	add_index_stringl(return_value, 3, buf, len);
 	add_assoc_stringl(return_value, "length", buf, len);
 
+	/*
+	* SQL_ consts are part of Firebird-API.
+	*/
+
 	if (var->sqlscale < 0) {
 		unsigned short precision = 0;
 

php_interbase.h

@@ -25,7 +25,7 @@ extern zend_module_entry ibase_module_entry;
 #define phpext_interbase_ptr &ibase_module_entry
 
 #include "php_version.h"
-#define PHP_INTERBASE_VERSION "1.0.0-dev"
+#define PHP_INTERBASE_VERSION "1.1.0-beta"
 
 PHP_MINIT_FUNCTION(ibase);
 PHP_RINIT_FUNCTION(ibase);