Using new default.

cincuranet · cincuranet · commit dcdecfadc7b8 · 2018-07-09T14:05:24.000+02:00
diff --git a/Provider/src/EntityFramework.Firebird/FbProviderServices.cs b/Provider/src/EntityFramework.Firebird/FbProviderServices.cs
@@ -187,7 +187,7 @@ private static FbDbType GetSqlDbType(TypeUsage type, bool isOutParam, out int? s
 			// only supported for primitive type
 			PrimitiveTypeKind primitiveTypeKind = MetadataHelpers.GetPrimitiveTypeKind(type);
 
-			size = default(int?);
+			size = default;
 
 			switch (primitiveTypeKind)
 			{
@@ -252,7 +252,7 @@ private static FbDbType GetSqlDbType(TypeUsage type, bool isOutParam, out int? s
 			else
 			{
 				// no value
-				return default(int?);
+				return default;
 			}
 		}
 
@@ -283,7 +283,7 @@ private static FbDbType GetStringDbType(TypeUsage type)
 				{
 					maxLength = (unicode ? FbProviderManifest.UnicodeVarcharMaxSize : FbProviderManifest.AsciiVarcharMaxSize);
 				}
-				if (maxLength == default(int?) || maxLength > (unicode ? FbProviderManifest.UnicodeVarcharMaxSize : FbProviderManifest.AsciiVarcharMaxSize))
+				if (maxLength == default || maxLength > (unicode ? FbProviderManifest.UnicodeVarcharMaxSize : FbProviderManifest.AsciiVarcharMaxSize))
 				{
 					dbType = FbDbType.Text;
 				}
diff --git a/Provider/src/EntityFramework.Firebird/MetadataHelpers.cs b/Provider/src/EntityFramework.Firebird/MetadataHelpers.cs
@@ -159,7 +159,7 @@ internal static bool TryGetPrimitiveTypeKind(TypeUsage type, out PrimitiveTypeKi
 				return true;
 			}
 
-			typeKind = default(PrimitiveTypeKind);
+			typeKind = default;
 			return false;
 		}
 
@@ -184,7 +184,7 @@ internal static T TryGetValueForMetadataProperty<T>(MetadataItem item, string pr
 		{
 			if (!item.MetadataProperties.TryGetValue(propertyName, true, out var property))
 			{
-				return default(T);
+				return default;
 			}
 
 			return (T)property.Value;
@@ -352,7 +352,7 @@ internal static bool TryGetIntFacetValue(TypeUsage type, string facetName, out i
 				if (!intFacet.IsUnbounded)
 					intValue = (int)intFacet.Value;
 				else
-					intValue = default(int?);
+					intValue = default;
 				return true;
 			}
 
@@ -428,7 +428,7 @@ internal static ParameterDirection ParameterModeToParameterDirection(ParameterMo
 
 				default:
 					Debug.Fail("unrecognized mode " + mode.ToString());
-					return default(ParameterDirection);
+					return default;
 			}
 		}
 
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbArrayTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbArrayTests.cs
@@ -27,7 +27,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbArrayTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbBlobTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbBlobTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbBlobTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbBooleanSupportTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbBooleanSupportTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbBooleanSupportTests : FbTestsBase
 	{
 		private bool _shouldTearDown;
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbCommandBuilderTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbCommandBuilderTests.cs
@@ -24,7 +24,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbCommandBuilderTests : FbTestsBase
 	{
 		#region Fields
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbCommandTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbCommandTests.cs
@@ -28,7 +28,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbCommandTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbConnectionTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbConnectionTests.cs
@@ -28,7 +28,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbConnectionTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDataAdapterTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDataAdapterTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbDataAdapterTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDataReaderTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDataReaderTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbDataReaderTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseInfoTests.cs
@@ -24,7 +24,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbDatabaseInfoTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseSchemaTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbDatabaseSchemaTests.cs
@@ -24,7 +24,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbDatabaseSchemaTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbExceptionTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbExceptionTests.cs
@@ -23,7 +23,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	class FbExceptionTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbImplicitTransactionTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbImplicitTransactionTests.cs
@@ -26,7 +26,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbImplicitTransactionTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbParameterTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbParameterTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbParameterTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbStoredProcCallsTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbStoredProcCallsTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbStoredProcCallsTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbTransactionTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/FbTransactionTests.cs
@@ -24,7 +24,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class FbTransactionTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/GuidTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/GuidTests.cs
@@ -24,7 +24,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class GuidTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/TrackerIssuesTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/TrackerIssuesTests.cs
@@ -29,7 +29,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class TrackerIssuesTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/TransactionScopeTests.cs b/Provider/src/FirebirdSql.Data.FirebirdClient.Tests/TransactionScopeTests.cs
@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests
 {
 	[FbTestFixture(FbServerType.Default, false)]
 	[FbTestFixture(FbServerType.Default, true)]
-	[FbTestFixture(FbServerType.Embedded, default(bool))]
+	[FbTestFixture(FbServerType.Embedded, default)]
 	public class TransactionScopeTests : FbTestsBase
 	{
 		#region Constructors
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient/Common/ArrayBase.cs b/Provider/src/FirebirdSql.Data.FirebirdClient/Common/ArrayBase.cs
@@ -170,7 +170,7 @@ protected int GetSliceLength(bool read)
 
 		protected Type GetSystemType()
 		{
-			return TypeHelper.GetTypeFromBlrType(_descriptor.DataType, default(int), _descriptor.Scale);
+			return TypeHelper.GetTypeFromBlrType(_descriptor.DataType, default, _descriptor.Scale);
 		}
 
 		#endregion
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient/Common/RemoteEvent.cs b/Provider/src/FirebirdSql.Data.FirebirdClient/Common/RemoteEvent.cs
@@ -64,7 +64,7 @@ public void QueueEvents(ICollection<string> events)
 				throw new ArgumentOutOfRangeException(nameof(events), "Need to provide at least one event.");
 			if (events.Any(x => x.Length > MaxEventNameLength))
 				throw new ArgumentOutOfRangeException(nameof(events), $"Some events are longer than {MaxEventNameLength}.");
-			if (BuildEpb(events.ToList(), _ => default(int)).ToArray().Length > MaxEpbLength)
+			if (BuildEpb(events.ToList(), _ => default).ToArray().Length > MaxEpbLength)
 				throw new ArgumentOutOfRangeException(nameof(events), $"Whole events buffer is bigger than {MaxEpbLength}.");
 			_events.AddRange(events);
 			QueueEventsImpl();
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient/Common/TraceHelper.cs b/Provider/src/FirebirdSql.Data.FirebirdClient/Common/TraceHelper.cs
@@ -35,7 +35,7 @@ static TraceHelper()
 
 		public static void Trace(TraceEventType eventType, string message)
 		{
-			_instance.TraceEvent(eventType, default(int), message);
+			_instance.TraceEvent(eventType, default, message);
 			_instance.Flush();
 		}
 
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbConnectionPoolManager.cs b/Provider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbConnectionPoolManager.cs
@@ -54,7 +54,7 @@ public void Dispose()
 					if (_disposed)
 						return;
 					_disposed = true;
-					Created = default(long);
+					Created = default;
 					Connection.Dispose();
 					Connection = null;
 				}
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbParameter.cs b/Provider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbParameter.cs
@@ -259,7 +259,7 @@ internal object InternalValue
 
 		internal bool HasSize
 		{
-			get { return _size != default(int); }
+			get { return _size != default; }
 		}
 
 		#endregion
diff --git a/Provider/src/FirebirdSql.Data.FirebirdClient/Isql/FbScript.cs b/Provider/src/FirebirdSql.Data.FirebirdClient/Isql/FbScript.cs
@@ -122,7 +122,7 @@ static bool IsSetTermStatement(string statement, out string newTerm)
 				return true;
 			}
 
-			newTerm = default(string);
+			newTerm = default;
 			return false;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ private static FbDbType GetSqlDbType(TypeUsage type, bool isOutParam, out int? s`
`187`	`187`	`// only supported for primitive type`
`188`	`188`	`PrimitiveTypeKind primitiveTypeKind = MetadataHelpers.GetPrimitiveTypeKind(type);`
`189`	`189`
`190`		`- size = default(int?);`
	`190`	`+ size = default;`
`191`	`191`
`192`	`192`	`switch (primitiveTypeKind)`
`193`	`193`	`{`
`@@ -252,7 +252,7 @@ private static FbDbType GetSqlDbType(TypeUsage type, bool isOutParam, out int? s`
`252`	`252`	`else`
`253`	`253`	`{`
`254`	`254`	`// no value`
`255`		`- return default(int?);`
	`255`	`+ return default;`
`256`	`256`	`}`
`257`	`257`	`}`
`258`	`258`
`@@ -283,7 +283,7 @@ private static FbDbType GetStringDbType(TypeUsage type)`
`283`	`283`	`{`
`284`	`284`	`maxLength = (unicode ? FbProviderManifest.UnicodeVarcharMaxSize : FbProviderManifest.AsciiVarcharMaxSize);`
`285`	`285`	`}`
`286`		`- if (maxLength == default(int?) \|\| maxLength > (unicode ? FbProviderManifest.UnicodeVarcharMaxSize : FbProviderManifest.AsciiVarcharMaxSize))`
	`286`	`+ if (maxLength == default \|\| maxLength > (unicode ? FbProviderManifest.UnicodeVarcharMaxSize : FbProviderManifest.AsciiVarcharMaxSize))`
`287`	`287`	`{`
`288`	`288`	`dbType = FbDbType.Text;`
`289`	`289`	`}`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ internal static bool TryGetPrimitiveTypeKind(TypeUsage type, out PrimitiveTypeKi`
`159`	`159`	`return true;`
`160`	`160`	`}`
`161`	`161`
`162`		`- typeKind = default(PrimitiveTypeKind);`
	`162`	`+ typeKind = default;`
`163`	`163`	`return false;`
`164`	`164`	`}`
`165`	`165`
`@@ -184,7 +184,7 @@ internal static T TryGetValueForMetadataProperty<T>(MetadataItem item, string pr`
`184`	`184`	`{`
`185`	`185`	`if (!item.MetadataProperties.TryGetValue(propertyName, true, out var property))`
`186`	`186`	`{`
`187`		`- return default(T);`
	`187`	`+ return default;`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`return (T)property.Value;`
`@@ -352,7 +352,7 @@ internal static bool TryGetIntFacetValue(TypeUsage type, string facetName, out i`
`352`	`352`	`if (!intFacet.IsUnbounded)`
`353`	`353`	`intValue = (int)intFacet.Value;`
`354`	`354`	`else`
`355`		`- intValue = default(int?);`
	`355`	`+ intValue = default;`
`356`	`356`	`return true;`
`357`	`357`	`}`
`358`	`358`
`@@ -428,7 +428,7 @@ internal static ParameterDirection ParameterModeToParameterDirection(ParameterMo`
`428`	`428`
`429`	`429`	`default:`
`430`	`430`	`Debug.Fail("unrecognized mode " + mode.ToString());`
`431`		`- return default(ParameterDirection);`
	`431`	`+ return default;`
`432`	`432`	`}`
`433`	`433`	`}`
`434`	`434`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests`
`27`	`27`	`{`
`28`	`28`	`[FbTestFixture(FbServerType.Default, false)]`
`29`	`29`	`[FbTestFixture(FbServerType.Default, true)]`
`30`		`- [FbTestFixture(FbServerType.Embedded, default(bool))]`
	`30`	`+ [FbTestFixture(FbServerType.Embedded, default)]`
`31`	`31`	`public class FbArrayTests : FbTestsBase`
`32`	`32`	`{`
`33`	`33`	`#region Constructors`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests`
`25`	`25`	`{`
`26`	`26`	`[FbTestFixture(FbServerType.Default, false)]`
`27`	`27`	`[FbTestFixture(FbServerType.Default, true)]`
`28`		`- [FbTestFixture(FbServerType.Embedded, default(bool))]`
	`28`	`+ [FbTestFixture(FbServerType.Embedded, default)]`
`29`	`29`	`public class FbBlobTests : FbTestsBase`
`30`	`30`	`{`
`31`	`31`	`#region Constructors`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests`
`24`	`24`	`{`
`25`	`25`	`[FbTestFixture(FbServerType.Default, false)]`
`26`	`26`	`[FbTestFixture(FbServerType.Default, true)]`
`27`		`- [FbTestFixture(FbServerType.Embedded, default(bool))]`
	`27`	`+ [FbTestFixture(FbServerType.Embedded, default)]`
`28`	`28`	`public class FbCommandBuilderTests : FbTestsBase`
`29`	`29`	`{`
`30`	`30`	`#region Fields`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ namespace FirebirdSql.Data.FirebirdClient.Tests`
`28`	`28`	`{`
`29`	`29`	`[FbTestFixture(FbServerType.Default, false)]`
`30`	`30`	`[FbTestFixture(FbServerType.Default, true)]`
`31`		`- [FbTestFixture(FbServerType.Embedded, default(bool))]`
	`31`	`+ [FbTestFixture(FbServerType.Embedded, default)]`
`32`	`32`	`public class FbCommandTests : FbTestsBase`
`33`	`33`	`{`
`34`	`34`	`#region Constructors`