feat: close function to flush events

Author: SSebo

Cargo.lock

@@ -1,7 +1,7 @@
 [package]
 edition = "2021"
 name = "feature-probe-server-sdk"
-version = "1.1.0"
+version = "1.1.1"
 license = "Apache-2.0"
 authors = ["maintain@featureprobe.com"]
 description = "FeatureProbe Server Side SDK for Rust"
@@ -43,8 +43,8 @@ thiserror = "1.0"
 tracing = "0.1"
 url = "2"
 
-feature-probe-event-std = { optional = true, version = "1.0.4", package="feature-probe-event" }
-feature-probe-event-tokio = { optional = true, version = "1.0.4", features=["use_tokio"], default-features=false, package="feature-probe-event" }
+feature-probe-event-std = { optional = true, version = "1.1.2", package="feature-probe-event" }
+feature-probe-event-tokio = { optional = true, version = "1.1.2", features=["use_tokio"], default-features=false, package="feature-probe-event" }
 
 reqwest = { optional = true, version = "0.11", default-features = false, features = ["rustls-tls", "json"] }
 tokio = {optional = true, version = "1", features = ["full"]}
@@ -59,5 +59,5 @@ criterion = "0.3"
 rusty-hook = "^0.11.2"
 tokio = { version = "1", features = ["full"] }
 tracing-subscriber = "0.3"
-feature-probe-server = "1.0.4"
+feature-probe-server = "1.2.1"
 

Cargo.toml

@@ -6,13 +6,11 @@ use std::time::Duration;
 
 #[tokio::main]
 async fn main() {
-    // let _ = tracing_subscriber::fmt()
-    //     .with_env_filter("feature_probe_server_sdk=trace")
-    //     .init();
-
-    let remote_url = "https://featureprobe.io/server";
     // let remote_url = "http://localhost:4007"; // for local docker
+    let remote_url = "https://featureprobe.io/server";
+    // this key can fetch data, but can not change toggle
     let server_sdk_key = "server-8ed48815ef044428826787e9a238b9c6a479f98c";
+    // let server_sdk_key = /* paste server key from project list for changing toggle */;
     let interval = Duration::from_millis(2000);
     let config = FPConfig {
         remote_url: remote_url.to_owned(),
@@ -32,20 +30,14 @@ async fn main() {
         }
     };
 
-    let user = FPUser::new("user_id").with("city", "Paris");
-    let discount = fp.number_value("promotion_activity", &user, 9.0);
-    println!("Result => discount for user in Paris is : {:?}", discount);
+    let user = FPUser::new("unique user key");
+    let enable = fp.bool_value("campaign_enable", &user, false);
+    println!("Result => campaign_enable : {:?}", enable);
 
-    let detail = fp.number_detail("promotion_activity", &user, 9.0);
+    let detail = fp.bool_detail("campaign_enable", &user, false);
+    // println!("       => value : {:?}", detail.reason); // same as bool_value
     println!("       => reason : {:?}", detail.reason);
     println!("       => rule index  : {:?}", detail.rule_index);
 
-    let user2 = FPUser::new("user_id").with("city", "New York");
-    let discount2 = fp.number_value("promotion_activity", &user2, 9.0);
-    println!(
-        "Result => discount for user in New York is : {:?}",
-        discount2
-    );
-
-    tokio::time::sleep(interval).await;
+    fp.close();
 }

examples/demo.rs

@@ -35,6 +35,7 @@ pub struct FeatureProbe {
     #[cfg(any(feature = "event", feature = "event_tokio"))]
     event_recorder: Option<EventRecorder>,
     config: InnerConfig,
+    should_stop: Arc<RwLock<bool>>,
 }
 
 impl FeatureProbe {
@@ -115,9 +116,20 @@ impl FeatureProbe {
             syncer: None,
             #[cfg(any(feature = "event", feature = "event_tokio"))]
             event_recorder: None,
+            should_stop: Arc::new(RwLock::new(false)),
         }
     }
 
+    pub fn close(&self) {
+        if let Some(recorder) = &self.event_recorder {
+            recorder.flush();
+        }
+        let mut should_stop = self.should_stop.write();
+        *should_stop = true;
+
+        info!("featureprobe client closed");
+    }
+
     fn generic_detail<T: Default + Debug>(
         &self,
         toggle: &str,
@@ -202,7 +214,7 @@ impl FeatureProbe {
             self.config.http_client.clone(),
             repo,
         );
-        syncer.sync(self.config.wait_first_resp);
+        syncer.sync(self.config.wait_first_resp, self.should_stop.clone());
         self.syncer = Some(syncer);
         Ok(())
     }
@@ -216,12 +228,14 @@ impl FeatureProbe {
         };
         let flush_interval = self.config.refresh_interval;
         let auth = SdkAuthorization(self.config.server_sdk_key.clone()).encode();
+        let should_stop = self.should_stop.clone();
         let event_recorder = EventRecorder::new(
             events_url,
             auth,
             (*crate::USER_AGENT).clone(),
             flush_interval,
             100,
+            should_stop,
         );
         self.event_recorder = Some(event_recorder);
         Ok(())

src/feature_probe.rs

@@ -44,7 +44,7 @@ impl Synchronizer {
     }
 
     #[cfg(feature = "use_std")]
-    pub fn sync(&self, wait_first_resp: bool) {
+    pub fn sync(&self, wait_first_resp: bool, should_stop: Arc<RwLock<bool>>) {
         let inner = self.inner.clone();
         if wait_first_resp {
             inner.do_sync()
@@ -55,13 +55,16 @@ impl Synchronizer {
             }
             loop {
                 inner.do_sync();
+                if *should_stop.read() {
+                    break;
+                }
                 std::thread::sleep(inner.refresh_interval);
             }
         });
     }
 
     #[cfg(feature = "use_tokio")]
-    pub fn sync(&self, wait_first_resp: bool) {
+    pub fn sync(&self, wait_first_resp: bool, should_stop: Arc<RwLock<bool>>) {
         use std::sync::mpsc::sync_channel;
         let inner = self.inner.clone();
         let client = match &self.inner.client {
@@ -79,6 +82,9 @@ impl Synchronizer {
             }
             loop {
                 inner.do_sync(&client).await;
+                if *should_stop.read() {
+                    break;
+                }
                 interval.tick().await;
             }
         });
@@ -170,7 +176,8 @@ mod tests {
         let port = 9009;
         setup_mock_api(port).await;
         let syncer = build_synchronizer(port);
-        syncer.sync(true);
+        let should_stop = Arc::new(RwLock::new(false));
+        syncer.sync(true, should_stop);
 
         let repo = syncer.repository();
         let repo = repo.read();