Merge branch '3.0' into 3.x

Author: cowtowncoder

cbor/src/main/java/tools/jackson/dataformat/cbor/CBORParser.java

@@ -3378,6 +3378,25 @@ protected void _skipIncomplete() throws JacksonException
                 && type != CBORConstants.MAJOR_TYPE_BYTES) {
             _throwInternal();
         }
+
+        // [dataformats-binary#599]: If we are in a stringref namespace, we need to
+        // actually read and store the string/bytes value instead of just skipping it,
+        // so that later string references can find it.
+        // The finish methods will determine if the value should be added to the
+        // reference table based on shouldReferenceString().
+        if (!_stringRefs.empty()) {
+            if (type == CBORConstants.MAJOR_TYPE_TEXT) {
+                // Need to actually read the text (which may add to stringRefs)
+                _finishTextToken(_typeByte);
+            } else {
+                // For bytes: decode length then read (which may add to stringRefs)
+                int len = _decodeExplicitLength(_typeByte & 0x1F);
+                _finishBytes(len);
+            }
+            return;
+        }
+
+        // Standard skip logic when not in stringref namespace
         final int lowBits = _typeByte & 0x1F;
         if (lowBits <= 23) {
             if (lowBits > 0) {

cbor/src/test/java/module-info.java

@@ -24,5 +24,5 @@
     opens tools.jackson.dataformat.cbor.seq;
     opens tools.jackson.dataformat.cbor.testutil;
     opens tools.jackson.dataformat.cbor.testutil.failure;
-    opens tools.jackson.dataformat.cbor.tofix;
+    //opens tools.jackson.dataformat.cbor.tofix;
 }

cbor/src/test/java/tools/jackson/dataformat/cbor/tofix/StringRef599Test.java renamed to cbor/src/test/java/tools/jackson/dataformat/cbor/StringRef599Test.java

@@ -1,17 +1,16 @@
-package tools.jackson.dataformat.cbor.tofix;
+package tools.jackson.dataformat.cbor;
 
 import java.util.Arrays;
 
+import org.junit.jupiter.api.Test;
+
 import tools.jackson.core.JsonToken;
 import tools.jackson.databind.ObjectMapper;
 
 import tools.jackson.dataformat.cbor.*;
-import tools.jackson.dataformat.cbor.testutil.failure.JacksonTestFailureExpected;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-import org.junit.jupiter.api.Test;
-
 public class StringRef599Test extends CBORTestBase
 {
     private final ObjectMapper VANILLA_MAPPER = cborMapper();
@@ -27,7 +26,6 @@ public void testDupsNoStringRef() throws Exception
     }
 
     // [dataformats-binary#599]
-    @JacksonTestFailureExpected
     @Test
     public void testDupsWithStringRef() throws Exception
     {

ion/src/test/java/tools/jackson/dataformat/ion/IonNumberOverflowTest.java

@@ -81,9 +81,7 @@ public void testLongAsBigIntegerSize() throws Exception {
         IonParser bigIntLongParser = (IonParser) new IonFactory().createParser(ObjectReadContext.empty(),
                 bigIntLongValue.toString());
         assertEquals(JsonToken.VALUE_NUMBER_INT, bigIntLongParser.nextToken());
-        // 23-Oct-2025: Ion 1.11.11+ changed behavior: values that fit in long are now
-        //   classified as LONG (was BIG_INTEGER before)
-        assertEquals(JsonParser.NumberType.LONG, bigIntLongParser.getNumberType());
+        assertEquals(JsonParser.NumberType.BIG_INTEGER, bigIntLongParser.getNumberType());
         assertEquals(JsonParser.NumberTypeFP.UNKNOWN, bigIntLongParser.getNumberTypeFP());
         assertEquals(bigIntLongValue.longValue(), bigIntLongParser.getLongValue());
     }    

release-notes/CREDITS-2.x

@@ -422,3 +422,7 @@ Vincent Eigenberger (@beseder1)
  * Contributed fix for #601: Jackson subtype Avro schema unions are non-deterministic
    and therefore incompatible with each other
   (2.20.1)
+
+Yohei Kishimoto (@morokosi)
+ * Reported #599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+  (2.21.0)

release-notes/VERSION-2.x

@@ -16,17 +16,22 @@ Active maintainers:
 
 2.21.0 (not yet released)
 
+#599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+ (reported by Yohei K)
 #623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
  (requested by @Shaurya0108)
 
 2.20.1 (not yet released)
 
+#599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+ (reported by Yohei K)
 #601: Jackson subtype Avro schema unions are non-deterministic and therefore
   incompatible with each other
  (reported by Raphael W)
  (fix by Vincent E)
 #616: CBOR text gets truncated on decoding
  (reported, fix contributed by Manuel S)
+#623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
 
 2.20.0 (28-Aug-2025)
 
@@ -48,12 +53,16 @@ Active maintainers:
 
 2.19.3 (not yet released)
 
+#599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+ (reported by Yohei K)
 #601: Jackson subtype Avro schema unions are non-deterministic and therefore
   incompatible with each other
  (reported by Raphael W)
  (fix by Vincent E)
 #616: CBOR text gets truncated on decoding
  (reported, fix contributed by Manuel S)
+#623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
+ (requested by @Shaurya0108)
 
 2.19.2 (18-Jul-2025)
 
@@ -90,6 +99,13 @@ No changes since 2.19.1
 #571: Unable to deserialize a pojo with IonStruct
  (reported, fix contributed by Josh C)
 
+2.18.5 (not yet released)
+
+#599: (cbor) Unable to deserialize stringref-enabled CBOR with ignored properties
+ (reported by Yohei K)
+#623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
+ (requested by @Shaurya0108)
+
 2.18.4 (06-May-2025)
 
 #569: (ion) `IonParser` fails to parse some `long` values saying