Remove couple of deprecated methods (#5385)

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/deser/ValueInstantiator.java

@@ -5,11 +5,8 @@
 import java.math.BigInteger;
 
 import com.fasterxml.jackson.databind.*;
-import com.fasterxml.jackson.databind.cfg.CoercionAction;
-import com.fasterxml.jackson.databind.cfg.CoercionInputShape;
 import com.fasterxml.jackson.databind.deser.impl.PropertyValueBuffer;
 import com.fasterxml.jackson.databind.introspect.AnnotatedWithParams;
-import com.fasterxml.jackson.databind.type.LogicalType;
 
 /**
  * Class that defines simple API implemented by objects that create value
@@ -422,50 +419,6 @@ public Object createFromBoolean(DeserializationContext ctxt, boolean value) thro
      */
     public AnnotatedWithParams getWithArgsCreator() { return null; }
 
-    /*
-    /**********************************************************
-    /* Helper methods
-    /**********************************************************
-     */
-
-    /**
-     * @since 2.4 (demoted from <code>StdValueInstantiator</code>)
-     * @deprecated Since 2.12 should not handle coercions here
-     */
-    @Deprecated // since 2.12
-    @SuppressWarnings("resource")
-    protected Object _createFromStringFallbacks(DeserializationContext ctxt, String value)
-            throws IOException
-    {
-        // also, empty Strings might be accepted as null Object...
-        if (value.isEmpty()) {
-            if (ctxt.isEnabled(DeserializationFeature.ACCEPT_EMPTY_STRING_AS_NULL_OBJECT)) {
-                return null;
-            }
-        }
-
-        /* 28-Sep-2011, tatu: Ok this is not clean at all; but since there are legacy
-         *   systems that expect conversions in some cases, let's just add a minimal
-         *   patch (note: same could conceivably be used for numbers too).
-         */
-        if (canCreateFromBoolean()) {
-            // 29-May-2020, tatu: With 2.12 can and should use CoercionConfig so:
-            if (ctxt.findCoercionAction(LogicalType.Boolean, Boolean.class,
-                    CoercionInputShape.String) == CoercionAction.TryConvert) {
-                String str = value.trim();
-                if ("true".equals(str)) {
-                    return createFromBoolean(ctxt, true);
-                }
-                if ("false".equals(str)) {
-                    return createFromBoolean(ctxt, false);
-                }
-            }
-        }
-        return ctxt.handleMissingInstantiator(getValueClass(), this, ctxt.getParser(),
-                "no String-argument constructor/factory method to deserialize from String value ('%s')",
-                value);
-    }
-
     /*
     /**********************************************************
     /* Standard Base implementation (since 2.8)

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyBasedCreator.java

@@ -163,15 +163,6 @@ public static PropertyBasedCreator construct(DeserializationContext ctxt,
                 caseInsensitive, false);
     }
 
-    @Deprecated // since 2.9
-    public static PropertyBasedCreator construct(DeserializationContext ctxt,
-            ValueInstantiator valueInstantiator, SettableBeanProperty[] srcCreatorProps)
-        throws JsonMappingException
-    {
-        return construct(ctxt, valueInstantiator, srcCreatorProps,
-                ctxt.isEnabled(MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES));
-    }
-
     /**
      * Mutant factory method for constructing a map where the names of all properties
      * are transformed using the given {@link NameTransformer}.
@@ -302,11 +293,6 @@ static class CaseInsensitiveMap extends HashMap<String, SettableBeanProperty>
          */
         protected final Locale _locale;
 
-        @Deprecated // since 2.11
-        public CaseInsensitiveMap() {
-            this(Locale.getDefault());
-        }
-
         // @since 2.11
         public CaseInsensitiveMap(Locale l) {
             _locale = l;

src/main/java/com/fasterxml/jackson/databind/deser/impl/PropertyValueBuffer.java

@@ -119,14 +119,7 @@ public PropertyValueBuffer(JsonParser p, DeserializationContext ctxt, int paramC
         }
     }
 
-    @Deprecated // since 2.18
-    public PropertyValueBuffer(JsonParser p, DeserializationContext ctxt, int paramCount,
-            ObjectIdReader oir)
-    {
-        this(p, ctxt, paramCount, oir, null);
-    }
-
-    /**
+   /**
      * Returns {@code true} if the given property was seen in the JSON source by
      * this buffer.
      *