fix error msg when params not match (#296)

* fix error msg when params not match

* add UT

* rename ut name

* add ctor encode test

* fix typo

Author: arc0035

sdk-abi/src/main/java/org/fisco/bcos/sdk/abi/ABICodec.java

@@ -198,7 +198,6 @@ public String encodeMethodFromString(String ABI, String methodName, List<String>
                             + " , supported functions are: "
                             + contractABIDefinition.getFunctions().keySet());
         }
-        Throwable cause = null;
         for (ABIDefinition abiDefinition : methods) {
             if (abiDefinition.getInputs().size() == params.size()) {
                 ABIObject inputABIObject = abiObjectFactory.createInputObject(abiDefinition);
@@ -207,15 +206,13 @@ public String encodeMethodFromString(String ABI, String methodName, List<String>
                     String methodId = abiDefinition.getMethodId(cryptoSuite);
                     return methodId + abiCodecJsonWrapper.encode(inputABIObject, params).encode();
                 } catch (Exception e) {
-                    cause = e;
                     logger.error(" exception in encodeMethodFromString : {}", e.getMessage());
                 }
             }
         }
 
         String errorMsg =
-                " cannot encode in encodeMethodFromString with appropriate interface ABI, cause:"
-                        + cause.getMessage();
+                " cannot encode in encodeMethodFromString with appropriate interface ABI, make sure params match";
         logger.error(errorMsg);
         throw new ABICodecException(errorMsg);
     }

sdk-abi/src/test/java/org/fisco/bcos/sdk/test/abi/ABICodecTest.java

@@ -346,6 +346,42 @@ public void testEncodeFromString() {
         }
     }
 
+    @Test
+    public void testEncodeFromStringWithInvalidParams() {
+        List<String> args = new ArrayList<String>();
+        ABICodec abiCodec = new ABICodec(Utils.getCryptoSuite());
+        try {
+            abiCodec.encodeMethodFromString(abiDesc, "test", args);
+            Assert.fail();
+        } catch (Exception e) {
+            Assert.assertTrue(e instanceof ABICodecException);
+        }
+    }
+
+    @Test
+    public void testEncodeConsctructor() {
+        List<String> args = new ArrayList<String>();
+        ABICodec abiCodec = new ABICodec(Utils.getCryptoSuite());
+        try {
+            abiCodec.encodeConstructorFromString(abiDesc, "BIN", args);
+        } catch (Exception e) {
+            Assert.fail(e.getMessage());
+        }
+    }
+    @Test
+    public void testEncodeConsctructorWithInvalidParams() {
+        List<String> args = new ArrayList<String>();
+        args.add("invalid");
+        ABICodec abiCodec = new ABICodec(Utils.getCryptoSuite());
+        try {
+            abiCodec.encodeConstructorFromString(abiDesc, "BIN", args);
+            Assert.fail();
+        } catch (Exception e) {
+            Assert.assertTrue(e instanceof ABICodecException);
+        }
+    }
+
+
     @Test
     public void testEncodeByInterface() {
         ABICodec abiCodec = new ABICodec(Utils.getCryptoSuite());