Skip to content

Commit 67ca800

Browse files
authored
Merge pull request #891 from kyonRay/feature-3.7.0
<sync>(project): sync code from master.
2 parents 2ada6d8 + fb0898d commit 67ca800

File tree

6 files changed

+19
-7
lines changed

6 files changed

+19
-7
lines changed

.ci/ci_check.sh

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,9 +177,9 @@ LOG_INFO "------ check_standard_node---------"
177177
check_standard_node "true" "normal" "-A"
178178
rm -rf ./bin
179179

180-
LOG_INFO "------ download_binary: v3.2.3---------"
181-
download_build_chain "v3.2.3"
182-
download_binary "v3.2.3"
180+
LOG_INFO "------ download_binary: v3.2.6---------"
181+
download_build_chain "v3.2.6"
182+
download_binary "v3.2.6"
183183
LOG_INFO "------ check_standard_node---------"
184184
check_standard_node "false" "normal" "-A"
185185
LOG_INFO "------ check_sm_node---------"
@@ -203,6 +203,13 @@ rm -rf ./bin
203203
LOG_INFO "------ download_build_chain: v3.5.0---------"
204204
download_binary "v3.5.0"
205205
download_build_chain "v3.5.0"
206+
LOG_INFO "------ check_standard_node---------"
207+
check_standard_node "true"
208+
rm -rf ./bin
209+
210+
LOG_INFO "------ download_build_chain: v3.6.0---------"
211+
download_binary "v3.6.0"
212+
download_build_chain "v3.6.0"
206213
LOG_INFO "------ check_wasm_node---------"
207214
check_wasm_node "false"
208215
LOG_INFO "------ check_standard_node---------"

.github/workflows/workflow.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ jobs:
5050
if: runner.os == 'Windows'
5151
run: ./gradlew.bat build
5252
- name: run integration testing
53-
# FIXME: macOS WASM integration testing failed
5453
if: runner.os != 'Windows'
5554
run: /bin/bash .ci/ci_check.sh
5655

src/main/java/org/fisco/bcos/sdk/v3/transaction/manager/transactionv1/dto/BasicDeployRequest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ public BasicDeployRequest(
1919

2020
public BasicDeployRequest(
2121
String abi,
22+
String bin,
2223
BigInteger blockLimit,
2324
String nonce,
2425
BigInteger value,
@@ -27,6 +28,7 @@ public BasicDeployRequest(
2728
EIP1559Struct eip1559Struct,
2829
byte[] extension) {
2930
super(abi, "", "", blockLimit, nonce, value, gasPrice, gasLimit, eip1559Struct, extension);
31+
this.bin = bin;
3032
}
3133

3234
public String getBin() {
@@ -43,7 +45,7 @@ public void setTo(String to) {
4345

4446
@Override
4547
public boolean isTransactionEssentialSatisfy() {
46-
return super.isTransactionEssentialSatisfy() && bin != null;
48+
return bin != null;
4749
}
4850

4951
@Override

src/main/java/org/fisco/bcos/sdk/v3/transaction/manager/transactionv1/dto/DeployTransactionRequest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@ public DeployTransactionRequest(
2020

2121
public DeployTransactionRequest(
2222
String abi,
23+
String bin,
2324
BigInteger blockLimit,
2425
String nonce,
2526
BigInteger value,
2627
BigInteger gasPrice,
2728
BigInteger gasLimit,
2829
EIP1559Struct eip1559Struct,
2930
byte[] extension) {
30-
super(abi, blockLimit, nonce, value, gasPrice, gasLimit, eip1559Struct, extension);
31+
super(abi, bin, blockLimit, nonce, value, gasPrice, gasLimit, eip1559Struct, extension);
3132
}
3233

3334
public void setParams(List<Object> params) {

src/main/java/org/fisco/bcos/sdk/v3/transaction/manager/transactionv1/dto/DeployTransactionRequestWithStringParams.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@ public DeployTransactionRequestWithStringParams(
2020

2121
public DeployTransactionRequestWithStringParams(
2222
String abi,
23+
String bin,
2324
BigInteger blockLimit,
2425
String nonce,
2526
BigInteger value,
2627
BigInteger gasPrice,
2728
BigInteger gasLimit,
2829
EIP1559Struct eip1559Struct,
2930
byte[] extension) {
30-
super(abi, blockLimit, nonce, value, gasPrice, gasLimit, eip1559Struct, extension);
31+
super(abi, bin, blockLimit, nonce, value, gasPrice, gasLimit, eip1559Struct, extension);
3132
}
3233

3334
public void setStringParams(List<String> params) {

src/main/java/org/fisco/bcos/sdk/v3/transaction/manager/transactionv1/utils/TransactionRequestBuilder.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ public DeployTransactionRequest buildDeployRequest(List<Object> params)
137137
DeployTransactionRequest request =
138138
new DeployTransactionRequest(
139139
this.abi,
140+
this.bin,
140141
this.blockLimit,
141142
this.nonce,
142143
this.value,
@@ -163,6 +164,7 @@ public DeployTransactionRequestWithStringParams buildDeployStringParamsRequest(
163164
DeployTransactionRequestWithStringParams request =
164165
new DeployTransactionRequestWithStringParams(
165166
this.abi,
167+
this.bin,
166168
this.blockLimit,
167169
this.nonce,
168170
this.value,

0 commit comments

Comments
 (0)