Skip to content

Commit 091c8ec

Browse files
authored
fix BcosSdk crash bug (#415)
1 parent 57daecc commit 091c8ec

File tree

2 files changed

+30
-12
lines changed

2 files changed

+30
-12
lines changed

sdk-service/src/main/java/org/fisco/bcos/sdk/BcosSDK.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,24 +24,22 @@
2424

2525
public class BcosSDK {
2626
private static Logger logger = LoggerFactory.getLogger(BcosSDK.class);
27-
public static final String ECDSA_TYPE_STR = "ecdsa";
28-
public static final String SM_TYPE_STR = "sm";
2927

3028
private final ConfigOption config;
31-
private org.fisco.bcos.sdk.jni.BcosSDK jniBcosSdk;
29+
// private org.fisco.bcos.sdk.jni.BcosSDK jniBcosSdk;
3230
private org.fisco.bcos.sdk.jni.rpc.Rpc jniRpcImpl;
3331

3432
public ConfigOption getConfig() {
3533
return config;
3634
}
3735

38-
public org.fisco.bcos.sdk.jni.BcosSDK getJniBcosSdk() {
39-
return jniBcosSdk;
40-
}
41-
42-
public void setJniBcosSdk(org.fisco.bcos.sdk.jni.BcosSDK jniBcosSdk) {
43-
this.jniBcosSdk = jniBcosSdk;
44-
}
36+
// public org.fisco.bcos.sdk.jni.BcosSDK getJniBcosSdk() {
37+
// return jniBcosSdk;
38+
// }
39+
//
40+
// public void setJniBcosSdk(org.fisco.bcos.sdk.jni.BcosSDK jniBcosSdk) {
41+
// this.jniBcosSdk = jniBcosSdk;
42+
// }
4543

4644
/**
4745
* Build BcosSDK instance
@@ -67,9 +65,9 @@ public static BcosSDK build(String tomlConfigFilePath) throws BcosSDKException {
6765
* @throws BcosSDKException
6866
*/
6967
public BcosSDK(ConfigOption configOption) throws BcosSDKException {
70-
this.config = configOption;
7168
try {
72-
this.jniBcosSdk = org.fisco.bcos.sdk.jni.BcosSDK.build(configOption.getJniConfig());
69+
this.config = configOption;
70+
// this.jniBcosSdk = org.fisco.bcos.sdk.jni.BcosSDK.build(configOption.getJniConfig());
7371
this.jniRpcImpl = org.fisco.bcos.sdk.jni.rpc.Rpc.build(config.getJniConfig());
7472
} catch (Exception e) {
7573
logger.warn("error: {}", e);

src/integration-test/java/org/fisco/bcos/sdk/BcosSDKTest.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
package org.fisco.bcos.sdk;
1919

2020
import java.math.BigInteger;
21+
import java.util.List;
2122
import java.util.Random;
2223
import java.util.concurrent.CompletableFuture;
2324
import java.util.concurrent.ExecutionException;
@@ -345,4 +346,23 @@ public void testHelloWorldInLiquid() throws ConfigException, JniException, Contr
345346
s2 = helloWorld.get();
346347
System.out.println("helloworld get :" + s2);
347348
}
349+
350+
@Test
351+
public void testGetGroupList() throws ConfigException, JniException {
352+
ConfigOption configOption = Config.load(configFile);
353+
354+
System.out.println("configOption: " + configOption);
355+
356+
Client clientWithoutGroupId = Client.build(configOption);
357+
System.out.println("build clientWithoutGroupId");
358+
List<String> groupList = clientWithoutGroupId.getGroupList().getResult().getGroupList();
359+
System.out.println("getGroupList: " + groupList);
360+
361+
BcosSDK bcosSDK = new BcosSDK(configOption);
362+
for(String groupId: groupList) {
363+
Client client = bcosSDK.getClient(groupId);
364+
System.out.println("build client, groupId: " + groupId);
365+
System.out.println("getBlockNumber, blk: " + client.getBlockNumber().getBlockNumber());
366+
}
367+
}
348368
}

0 commit comments

Comments
 (0)