[plugin] improve client generation exception handling (#915)

dariuszkuc · smyrick · web-flow · commit b7ef5e41081e · 2020-10-24T14:44:56.000-07:00
* [plugin] improve client generation exception handling Changes * use typed exceptions instead of generic `RuntimeException` * validate whether fragments are valid Related: #903 * fix ktlint * Apply suggestions from code review Co-authored-by: Shane Myrick <mail@shanemyrick.com> * fix code to use updated exception Co-authored-by: Shane Myrick <mail@shanemyrick.com>
diff --git a/plugins/graphql-kotlin-plugin-core/build.gradle.kts b/plugins/graphql-kotlin-plugin-core/build.gradle.kts
@@ -23,12 +23,12 @@ tasks {
                 limit {
                     counter = "INSTRUCTION"
                     value = "COVEREDRATIO"
-                    minimum = "0.85".toBigDecimal()
+                    minimum = "0.90".toBigDecimal()
                 }
                 limit {
                     counter = "BRANCH"
                     value = "COVEREDRATIO"
-                    minimum = "0.65".toBigDecimal()
+                    minimum = "0.75".toBigDecimal()
                 }
             }
         }
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/GraphQLClientGenerator.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/GraphQLClientGenerator.kt
@@ -16,6 +16,7 @@
 
 package com.expediagroup.graphql.plugin.generator
 
+import com.expediagroup.graphql.plugin.generator.exceptions.MultipleOperationsInFileException
 import com.expediagroup.graphql.plugin.generator.types.generateGraphQLObjectTypeSpec
 import com.expediagroup.graphql.plugin.generator.types.generateVariableTypeSpec
 import com.squareup.kotlinpoet.ClassName
@@ -81,7 +82,7 @@ class GraphQLClientGenerator(
 
         val operationDefinitions = queryDocument.definitions.filterIsInstance(OperationDefinition::class.java)
         if (operationDefinitions.size > 1) {
-            throw RuntimeException("GraphQL client does not support query files with multiple operations")
+            throw MultipleOperationsInFileException
         }
 
         val fileSpec = FileSpec.builder(packageName = config.packageName, fileName = queryFile.nameWithoutExtension.capitalize())
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/DeprecatedFieldsSelectedException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/DeprecatedFieldsSelectedException.kt
@@ -0,0 +1,23 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+/**
+ * Exception thrown when query specifies deprecated fields but client configuration does not allow it.
+ */
+internal class DeprecatedFieldsSelectedException(field: String, type: String) :
+    RuntimeException("Operation specifies deprecated field - $field in $type. Update your operation or update your configuration to allow usage of deprecated fields")
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/InvalidFragmentException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/InvalidFragmentException.kt
@@ -0,0 +1,23 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+/**
+ * Exception thrown when query file specifies invalid fragment.
+ */
+internal class InvalidFragmentException(fragmentName: String, targetType: String) :
+    RuntimeException("Invalid fragment, $fragmentName fragment not found or does not reference valid $targetType type")
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/InvalidPolymorphicQueryException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/InvalidPolymorphicQueryException.kt
@@ -0,0 +1,22 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+/**
+ * Exception thrown when query contains invalid polymorphic selection sets.
+ */
+internal class InvalidPolymorphicQueryException(message: String) : RuntimeException(message)
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/InvalidSelectionSetException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/InvalidSelectionSetException.kt
@@ -0,0 +1,23 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+/**
+ * Exception thrown when specified query file contains invalid selection set.
+ */
+internal class InvalidSelectionSetException(typeDefinitionName: String, typeName: String) :
+    RuntimeException("Invalid selection set for $typeName - cannot select empty $typeDefinitionName")
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/MultipleOperationsInFileException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/MultipleOperationsInFileException.kt
@@ -0,0 +1,22 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+/**
+ * Exception thrown when attempting to generate a client from a query file containing multiple operations.
+ */
+internal object MultipleOperationsInFileException : RuntimeException("GraphQL client does not support query files with multiple operations")
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/UnknownFieldSelectedException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/UnknownFieldSelectedException.kt
@@ -0,0 +1,23 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+/**
+ * Exception thrown when specified query file references unknown fields.
+ */
+internal class UnknownFieldSelectedException(fieldName: String, typeDefinitionName: String) :
+    RuntimeException("Invalid selection set for $typeDefinitionName - unknown $fieldName field selected")
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/UnknownGraphQLTypeException.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/exceptions/UnknownGraphQLTypeException.kt
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.exceptions
+
+import graphql.language.Node
+
+/**
+ * This exception should never be thrown. It is used to enforce type safety of type name generation operations. Exception
+ * is used to mark unreachable code execution branches that ensures non null response from all valid branches.
+ */
+internal class UnknownGraphQLTypeException(graphQLType: Node<*>) :
+    RuntimeException("Client generation failure - attempting to generate code for unsupported GraphQL type $graphQLType")
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/extensions/DocumentExtensions.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/extensions/DocumentExtensions.kt
@@ -0,0 +1,25 @@
+/*
+ * Copyright 2020 Expedia, Inc
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.expediagroup.graphql.plugin.generator.extensions
+
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidFragmentException
+import graphql.language.Document
+import graphql.language.FragmentDefinition
+
+internal fun Document.findFragmentDefinition(targetFragment: String, targetType: String): FragmentDefinition =
+    this.getDefinitionsOfType(FragmentDefinition::class.java)
+        .find { it.name == targetFragment && it.typeCondition.name == targetType } ?: throw InvalidFragmentException(targetFragment, targetType)
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateGraphQLInterfaceTypeSpec.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateGraphQLInterfaceTypeSpec.kt
@@ -17,6 +17,7 @@
 package com.expediagroup.graphql.plugin.generator.types
 
 import com.expediagroup.graphql.plugin.generator.GraphQLClientGeneratorContext
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidSelectionSetException
 import com.squareup.kotlinpoet.TypeSpec
 import graphql.language.InterfaceTypeDefinition
 import graphql.language.SelectionSet
@@ -34,7 +35,7 @@ internal fun generateGraphQLInterfaceTypeSpec(
     interfaceNameOverride: String? = null
 ): TypeSpec {
     if (selectionSet == null || selectionSet.selections.isEmpty()) {
-        throw RuntimeException("cannot select empty interface")
+        throw InvalidSelectionSetException(interfaceDefinition.name, "interface")
     }
 
     val interfaceName = interfaceNameOverride ?: interfaceDefinition.name
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateGraphQLObjectTypeSpec.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateGraphQLObjectTypeSpec.kt
@@ -17,10 +17,11 @@
 package com.expediagroup.graphql.plugin.generator.types
 
 import com.expediagroup.graphql.plugin.generator.GraphQLClientGeneratorContext
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidSelectionSetException
+import com.expediagroup.graphql.plugin.generator.extensions.findFragmentDefinition
 import com.squareup.kotlinpoet.FunSpec
 import com.squareup.kotlinpoet.KModifier
 import com.squareup.kotlinpoet.TypeSpec
-import graphql.language.FragmentDefinition
 import graphql.language.FragmentSpread
 import graphql.language.ObjectTypeDefinition
 import graphql.language.SelectionSet
@@ -35,7 +36,7 @@ internal fun generateGraphQLObjectTypeSpec(
     objectNameOverride: String? = null
 ): TypeSpec {
     if (selectionSet == null || selectionSet.selections.isEmpty()) {
-        throw RuntimeException("cannot select empty objects")
+        throw InvalidSelectionSetException(objectDefinition.name, "object")
     }
 
     val typeName = objectNameOverride ?: objectDefinition.name
@@ -59,8 +60,7 @@ internal fun generateGraphQLObjectTypeSpec(
     selectionSet.getSelectionsOfType(FragmentSpread::class.java)
         .forEach { fragment ->
             val fragmentDefinition = context.queryDocument
-                .getDefinitionsOfType(FragmentDefinition::class.java)
-                .find { it.name == fragment.name } ?: throw RuntimeException("fragment not found")
+                .findFragmentDefinition(fragment.name, objectDefinition.name)
             generatePropertySpecs(
                 context = context,
                 objectName = objectDefinition.name,
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateGraphQLUnionTypeSpec.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateGraphQLUnionTypeSpec.kt
@@ -17,6 +17,7 @@
 package com.expediagroup.graphql.plugin.generator.types
 
 import com.expediagroup.graphql.plugin.generator.GraphQLClientGeneratorContext
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidSelectionSetException
 import com.squareup.kotlinpoet.TypeSpec
 import graphql.language.SelectionSet
 import graphql.language.TypeName
@@ -35,7 +36,7 @@ internal fun generateGraphQLUnionTypeSpec(
     unionNameOverride: String? = null
 ): TypeSpec {
     if (selectionSet == null || selectionSet.selections.isEmpty()) {
-        throw RuntimeException("cannot select empty union")
+        throw InvalidSelectionSetException(unionDefinition.name, "union")
     }
 
     val unionName = unionNameOverride ?: unionDefinition.name
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateInterfaceTypeSpec.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateInterfaceTypeSpec.kt
@@ -17,6 +17,8 @@
 package com.expediagroup.graphql.plugin.generator.types
 
 import com.expediagroup.graphql.plugin.generator.GraphQLClientGeneratorContext
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidFragmentException
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidPolymorphicQueryException
 import com.fasterxml.jackson.annotation.JsonSubTypes
 import com.fasterxml.jackson.annotation.JsonTypeInfo
 import com.squareup.kotlinpoet.AnnotationSpec
@@ -60,7 +62,9 @@ internal fun generateInterfaceTypeSpec(
     }
 
     val namedFragments = selectionSet.getSelectionsOfType(FragmentSpread::class.java).map { fragment ->
-        context.queryDocument.getDefinitionsOfType(FragmentDefinition::class.java).find { it.name == fragment.name } ?: throw RuntimeException("fragment ${fragment.name} not found")
+        // polymorphic selection set can contain selection set against interface or concrete types
+        context.queryDocument.getDefinitionsOfType(FragmentDefinition::class.java)
+            .find { it.name == fragment.name } ?: throw InvalidFragmentException(fragment.name, interfaceName)
     }.associateBy { it.typeCondition.name }
 
     // find super selection set that contains
@@ -108,15 +112,15 @@ internal fun generateInterfaceTypeSpec(
     // check if all implementations are selected
     val notImplemented = implementations.minus(implementationSelections.keys)
     if (notImplemented.isNotEmpty()) {
-        throw RuntimeException("query does not specify all polymorphic implementations - $interfaceName field selection is missing $notImplemented")
+        throw InvalidPolymorphicQueryException("query does not specify all polymorphic implementations - $interfaceName field selection is missing $notImplemented")
     }
 
     // generate implementations with final selection set
     val jsonSubTypesCodeBlock = CodeBlock.builder()
     implementationSelections.forEach { implementationName, (typeCondition, selections) ->
         val distinctSelections = selections.filterIsInstance(Field::class.java).distinctBy { if (it.alias != null) it.alias else it.name }
         if (!verifyTypeNameIsSelected(distinctSelections)) {
-            throw RuntimeException("invalid selection set - $implementationName implementation of $interfaceName is missing __typename field in its selection set")
+            throw InvalidPolymorphicQueryException("invalid polymorphic selection set - $implementationName implementation of $interfaceName is missing __typename field in its selection set")
         }
         val implementationClassName = generateTypeName(context, typeCondition, SelectionSet.newSelectionSet(distinctSelections).build()) as ClassName
         val simpleName = implementationClassName.simpleName.substringAfter('.')
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generatePropertySpecs.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generatePropertySpecs.kt
@@ -17,6 +17,8 @@
 package com.expediagroup.graphql.plugin.generator.types
 
 import com.expediagroup.graphql.plugin.generator.GraphQLClientGeneratorContext
+import com.expediagroup.graphql.plugin.generator.exceptions.DeprecatedFieldsSelectedException
+import com.expediagroup.graphql.plugin.generator.exceptions.InvalidSelectionSetException
 import com.squareup.kotlinpoet.AnnotationSpec
 import com.squareup.kotlinpoet.PropertySpec
 import graphql.Directives.DeprecatedDirective
@@ -45,7 +47,7 @@ internal fun generatePropertySpecs(
     }
     .map { selectedField ->
         val fieldDefinition = fieldDefinitions.find { it.name == selectedField.name }
-            ?: throw RuntimeException("unable to find corresponding field definition of ${selectedField.name} in $objectName")
+            ?: throw InvalidSelectionSetException(selectedField.name, objectName)
 
         val nullable = fieldDefinition.type !is NonNullType
         val kotlinFieldType = generateTypeName(context, fieldDefinition.type, selectedField.selectionSet)
@@ -57,7 +59,7 @@ internal fun generatePropertySpecs(
         }
         fieldDefinition.getDirective(DeprecatedDirective.name)?.let { deprecatedDirective ->
             if (!context.allowDeprecated) {
-                throw RuntimeException("query specifies deprecated field - ${selectedField.name} in $objectName, update your query or update your configuration to allow usage of deprecated fields")
+                throw DeprecatedFieldsSelectedException(selectedField.name, objectName)
             } else {
                 val deprecatedReason = deprecatedDirective.getArgument("reason")?.value as? StringValue
                 val reason = deprecatedReason?.value ?: "no longer supported"
diff --git a/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateTypeName.kt b/plugins/graphql-kotlin-plugin-core/src/main/kotlin/com/expediagroup/graphql/plugin/generator/types/generateTypeName.kt
diff --git a/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLClientIT.kt b/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLClientIT.kt
diff --git a/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLInterfaceTypeSpecIT.kt b/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLInterfaceTypeSpecIT.kt
diff --git a/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLObjectTypeSpecIT.kt b/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLObjectTypeSpecIT.kt
diff --git a/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLUnionTypeSpecIT.kt b/plugins/graphql-kotlin-plugin-core/src/test/kotlin/com/expediagroup/graphql/plugin/generator/types/GenerateGraphQLUnionTypeSpecIT.kt

Original file line number	Diff line number	Diff line change
`@@ -23,12 +23,12 @@ tasks {`
`23`	`23`	`limit {`
`24`	`24`	`counter = "INSTRUCTION"`
`25`	`25`	`value = "COVEREDRATIO"`
`26`		`- minimum = "0.85".toBigDecimal()`
	`26`	`+ minimum = "0.90".toBigDecimal()`
`27`	`27`	`}`
`28`	`28`	`limit {`
`29`	`29`	`counter = "BRANCH"`
`30`	`30`	`value = "COVEREDRATIO"`
`31`		`- minimum = "0.65".toBigDecimal()`
	`31`	`+ minimum = "0.75".toBigDecimal()`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`}`