Remove redundant call to publish_page() (#1355)

* Remove rendundant call to publish_page()

As the page is already published, this was causing Django-CMS to fail
with a `NodeAlreadySaved` exception from treebeard. The only thing it
looked to be doing that `cms.api.create_page()` was not was assigning a
user to the page, and this can already be done with `create_page()`
using the `created_by` argument.

Fixex #1349.

* Re-enable test disabled in #1348 (706617e)

Author: kgaughan

conference/management/commands/create_initial_data_for_dev.py

@@ -127,6 +127,7 @@ def new_page(rev_id, title, **kwargs):
                         "generic_content_page_with_sidebar.html"
                     ),
                     published=True,
+                    created_by=admin.user,
                     publication_date=timezone.now(),
                     in_navigation=True,
                     **kwargs,
@@ -137,7 +138,6 @@ def new_page(rev_id, title, **kwargs):
                     language="en",
                     body=f"This is the page content for {title}",
                 )
-                publish_page(page, user=admin.user, language="en")
                 print("Created page: ", page.reverse_id, title, page.template)
                 return page
 

tests/test_provisioning_script.py

@@ -4,8 +4,6 @@
 from pytest import mark
 
 
-# XXX This will have to be investigated further, but not now...
-@mark.skip(reason='Getting a weird error from the script')
 @mark.django_db
 def test_basic_create_initial_data_for_dev_run():