GH-1218 Add error message for incorrect stack number and update validation logic (#1218)

* Add error message for incorrect stack number and update validation logic

* Remove `<bold>` to use follow other messages' layout.

Author: CitralFlo

eternalcore-core/src/main/java/com/eternalcode/core/feature/item/ItemCommand.java

@@ -10,7 +10,6 @@
 import dev.rollczi.litecommands.annotations.command.Command;
 import dev.rollczi.litecommands.annotations.context.Context;
 import dev.rollczi.litecommands.annotations.execute.Execute;
-import dev.rollczi.litecommands.annotations.optional.OptionalArg;
 import dev.rollczi.litecommands.annotations.permission.Permission;
 import org.bukkit.Material;
 import org.bukkit.entity.Player;
@@ -38,7 +37,7 @@ void execute(@Context Player player, @Arg Material material) {
 
     @Execute
     @DescriptionDocs(description = "Gives an item with a custom amount", arguments = "<item> [amount]")
-    void execute(@Context Player player, @Arg Material material, @OptionalArg(StackAmountArgument.KEY) int amount) {
+    void execute(@Context Player player, @Arg Material material, @Arg(StackAmountArgument.KEY) int amount) {
         boolean isSuccess = this.giveService.giveItem(player, player, material, amount);
 
         if (isSuccess) {

eternalcore-core/src/main/java/com/eternalcode/core/litecommand/argument/StackAmountArgument.java

@@ -29,14 +29,14 @@ public ParseResult<Integer> parse(Invocation<CommandSender> invocation, String a
         try {
             int value = Integer.parseInt(argument);
 
-            if (value < 0) {
-                return ParseResult.failure(translation.argument().numberBiggerThanOrEqualZero());
+            if (value <= 0) {
+                return ParseResult.failure(translation.argument().numberBiggerThanZero());
             }
 
             return ParseResult.success(value);
         }
         catch (NumberFormatException exception) {
-            return ParseResult.failure(translation.argument().numberBiggerThanOrEqualZero());
+            return ParseResult.failure(translation.argument().stackNumberIncorrect());
         }
     }
 

eternalcore-core/src/main/java/com/eternalcode/core/litecommand/argument/messages/ArgumentMessages.java

@@ -12,6 +12,7 @@ public interface ArgumentMessages {
     Notice onlyPlayer();
     Notice numberBiggerThanZero();
     Notice numberBiggerThanOrEqualZero();
+    Notice stackNumberIncorrect();
     Notice noItem();
     Notice noMaterial();
     Notice noArgument();

eternalcore-core/src/main/java/com/eternalcode/core/litecommand/argument/messages/ENArgumentMessages.java

@@ -23,6 +23,7 @@ public class ENArgumentMessages extends OkaeriConfig implements ArgumentMessages
     Notice onlyPlayer = Notice.chat("<red>✘ <dark_red>Command is only for players!");
     Notice numberBiggerThanZero = Notice.chat("<red>✘ <dark_red>The number must be greater than 0!");
     Notice numberBiggerThanOrEqualZero = Notice.chat("<red>✘ <dark_red>The number must be greater than or equal to 0!");
+    Notice stackNumberIncorrect = Notice.chat("<red>✘ <dark_red>Incorrect number!");
     Notice noItem = Notice.chat("<red>✘ <dark_red>You need item to use this command!");
     Notice noMaterial = Notice.chat("<red>✘ <dark_red>This item doesn't exist");
     Notice noArgument = Notice.chat("<red>✘ <dark_red>This argument doesn't exist");

eternalcore-core/src/main/java/com/eternalcode/core/litecommand/argument/messages/PLArgumentMessages.java

@@ -24,6 +24,7 @@ public class PLArgumentMessages extends OkaeriConfig implements ArgumentMessages
     Notice onlyPlayer = Notice.chat("<red>✘ <dark_red>Ta komenda jest dostępna tylko dla graczy!");
     Notice numberBiggerThanZero = Notice.chat("<red>✘ <dark_red>Liczba musi być większa od 0!");
     Notice numberBiggerThanOrEqualZero = Notice.chat("<red>✘ <dark_red>Liczba musi być równa lub większa od 0!");
+    Notice stackNumberIncorrect = Notice.chat("<red>✘ <dark_red><Niepoprawna liczba!");
     Notice noItem = Notice.chat("<red>✘ <dark_red>Musisz trzymać przedmiot w dłoni!");
     Notice noMaterial = Notice.chat("<red>✘ <dark_red>Taki materiał nie istnieje!");
     Notice noArgument = Notice.chat("<red>✘ <dark_red>Taki argument nie istnieje!");