replace clear button on required date time fields (#351)

* replace clear button from required date time fields with date time picker dialog button

* just use the edit calendar icon.

---------

Co-authored-by: Soren Roth <sor10874@esri.com>

Author: sorenoid

toolkit/featureforms/src/androidTest/java/com/arcgismaps/toolkit/featureforms/DateTimeFieldTests.kt

@@ -117,7 +117,7 @@ class DateTimeFieldTests {
             "expected helper text: Date Entry is Required"
 
         }
-        val iconMatcher = hasContentDescription("field icon")
+        val iconMatcher = hasContentDescription("date time picker button")
         assert(iconMatcher.matches(dateTimeField.fetchSemanticsNode()))
     }
 
@@ -136,7 +136,7 @@ class DateTimeFieldTests {
         val col = composeTestRule.onNodeWithContentDescription("lazy column")
         col.performScrollToIndex(8)
         val dateTimeField = composeTestRule.onNodeWithText("${formElement.label} *")
-        val iconMatcher = hasContentDescription("field icon")
+        val iconMatcher = hasContentDescription("date time picker button")
         assert(iconMatcher.matches(dateTimeField.fetchSemanticsNode()))
         dateTimeField.assertHasClickAction()
         dateTimeField.performClick()
@@ -150,7 +150,6 @@ class DateTimeFieldTests {
         helperTextInDialog.assertIsDisplayed()
     }
 
-    
     /**
      * Given a FieldFormElement with an editable datetime input
      * When the date value is displayed

toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/internal/components/datetime/DateTimeField.kt

@@ -21,8 +21,8 @@ package com.arcgismaps.toolkit.featureforms.internal.components.datetime
 import androidx.compose.foundation.interaction.MutableInteractionSource
 import androidx.compose.foundation.interaction.PressInteraction
 import androidx.compose.material.icons.Icons
-import androidx.compose.material.icons.rounded.CalendarMonth
 import androidx.compose.material.icons.rounded.EditCalendar
+import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
@@ -76,8 +76,19 @@ internal fun DateTimeField(
         isRequired = isRequired,
         singleLine = true,
         interactionSource = interactionSource,
-        trailingIcon = if (isEditable) Icons.Rounded.EditCalendar else Icons.Rounded.CalendarMonth,
-        onFocusChange = state::onFocusChanged
+        trailingIcon = Icons.Rounded.EditCalendar,
+        onFocusChange = state::onFocusChanged,
+        trailingContent =
+        if (isRequired) {
+            {
+                Icon(
+                    imageVector = Icons.Rounded.EditCalendar,
+                    contentDescription = "date time picker button"
+                )
+            }
+        } else {
+            null
+        }
     )
 
     LaunchedEffect(interactionSource) {