Access List show does not show Client IP address ranges

[Cloudineer]

Describe the bug
Running the command ./npm-api.sh --access-list-show 5 produces a valid output except the IP Whitelist shows No IPs whitelisted which is not correct.

To Reproduce
Steps to reproduce the behavior:

1. Command ./npm-api.sh --access-list-show 5 - replacing 5 with the ID of any access list with Access List rules.
2. Output should NOT be:

│ IP Whitelist
├================================================================================┤
│ No IPs whitelisted
└================================================================================┘

Expected behavior
A list of IP address ranges should be shown.

Screenshots
If applicable, add screenshots to help explain your problem.

Operating System:

• OS: Ubuntu
• Version Ubuntu 24.04.3 LTS

Additional context
After using chrome dev tools to check the query sent by the NPM client, the following code change fixed the issue.

$ git diff npm-api.sh
diff --git a/npm-api.sh b/npm-api.sh
index d9f714d..3e27d1d 100755
--- a/npm-api.sh
+++ b/npm-api.sh
@@ -3416,7 +3416,7 @@ access_list_show() {
     echo -e "\n📋 ${COLOR_CYAN}Access List Details${CoR}"
     
     # Get specific access list
-    local response=$(curl -s -X GET "$BASE_URL/nginx/access-lists/$id" \
+    local response=$(curl -s -X GET "$BASE_URL/nginx/access-lists/$id?expand=items%2Cclients" \
         -H "Authorization: Bearer $(cat "$TOKEN_FILE")")
 
     # Check if response is valid JSON

It seems there is a change in the API. I can submit a pull request if you prefer.

[Erreur32]

@Cloudineer
Oh, I hadn’t noticed the API changes. I’ll check if any other modifications were introduced so I can fix everything if needed.

Thanks for the feedback and If there are no additional changes, no problem for the PR ;)
I’ll be back soon.

[Erreur32]

You were absolutely right - the API schema changed and we needed to add the expand parameter to get the full details.

What was fixed

I've updated the code to include ?expand=items%2Cclients in the API calls for:

• access_list_show() function
• access_list_update() function
• full_backup() function (bonus improvement for complete backups)

Changes made

The fix is exactly what you suggested in your issue comment:

- local response=$(curl -s -X GET "$BASE_URL/nginx/access-lists/$id" \
+ local response=$(curl -s -X GET "$BASE_URL/nginx/access-lists/$id?expand=items%2Cclients" \
      -H "Authorization: Bearer $(cat "$TOKEN_FILE")")

I also applied the same fix to access_list_update() since it had the same issue when fetching current details.

Testing

You can now test it with:

./npm-api.sh --access-list-show 5

The IP whitelist should now display correctly! 🎉

Additional improvements

While fixing this, I also:

• Fixed the "unbound variable" error when running --access-list-show without an ID (now shows a helpful error message)
• Enhanced the backup function to fetch each access list individually with expand for complete backups

This will be included in version 3.0.7.

Thanks again for catching this and providing the solution! 🙏