refactor: other small changes to satisfy clippy

Author: Erenoit

src/bot/commands/music/music.rs

@@ -207,7 +207,7 @@ pub async fn list(ctx: Context<'_>) -> Result<(), Error> {
         .await?
         .iter()
         .for_each(|result| {
-            _ = writeln!(
+            writeln!(
                 msg,
                 "**{}**: <{}>",
                 result
@@ -216,7 +216,8 @@ pub async fn list(ctx: Context<'_>) -> Result<(), Error> {
                     .expect("There is a `-` in prefix. This cannot fail.")
                     .1,
                 result.value
-            );
+            )
+            .ok();
         });
 
         msg += "\n";

src/bot/event.rs

@@ -35,6 +35,7 @@ impl EventHandler for Handler {
         }
 
         log!(info, "{} is online!", (ready.user.name.magenta()));
+        drop(servers);
     }
 
     async fn guild_create(&self, _ctx: Context, guild: Guild, is_new: bool) {

src/bot/mod.rs

@@ -24,6 +24,7 @@ pub struct Bot;
 
 impl Bot {
     /// Creates a new instance of the bot.
+    #[must_use]
     pub const fn new() -> Self { Self }
 
     /// Runs the bot.

src/messager.rs

@@ -191,10 +191,10 @@ macro_rules! selection {
 
             let mut msg = String::with_capacity(1024);
 
-            _ = writeln!(msg, "**{}**", $title);
+            writeln!(msg, "**{}**", $title).ok();
 
             for (i, element) in $list.iter().enumerate() {
-                _ = write!(msg, "{}) ", i + 1);
+                write!(msg, "{}) ", i + 1).ok();
                 msg.push_str(&element.0);
                 msg.push('\n');
             }
@@ -215,15 +215,15 @@ macro_rules! selection {
 /// This is an inner function for `selection!()` macro. Do not use!
 macro_rules! selection_inner {
     (clear, $ctx:expr, $interaction:ident) => {
-        _ = $interaction
+        $interaction
             .create_interaction_response($ctx.serenity_context(), |r| {
                 r.kind(serenity::model::application::interaction::InteractionResponseType::UpdateMessage)
                     .interaction_response_data(|d| {
                         d.content("An action has already been taken.")
                             .set_components(serenity::builder::CreateComponents::default())
                     })
             })
-            .await;
+            .await.ok();
     };
     (get_interaction, $ctx:expr, $res:ident, $n:lifetime, $def_return:expr) => {
         {
@@ -240,11 +240,11 @@ macro_rules! selection_inner {
                     std::time::Duration::from_secs(get_config!().message_interaction_time_limit())
                 ).await else
                 {
-                    _ = handle.edit($ctx, |m| {
+                    handle.edit($ctx, |m| {
                         m.content("Interaction timed out.").components(|c| {
                             c.create_action_row(|row| row)
                         })
-                    }).await;
+                    }).await.ok();
                     break $n $def_return;
             };
 

src/player/mod.rs

@@ -96,9 +96,10 @@ impl Player {
         }
 
         if let Some(call_mutex) = get_call_mutex!(self.guild_id) {
-            let mut call = call_mutex.lock().await;
-
-            call.leave()
+            call_mutex
+                .lock()
+                .await
+                .leave()
                 .await
                 .expect("There should be no error while leaving the call");
         }
@@ -154,13 +155,10 @@ impl Player {
                 if now_playing.is_some() {
                     (*now_playing).take().expect("Cannot be None at this point")
                 } else {
-                    let Some(song) = self.song_queue
-                        .lock()
-                        .await
-                        .pop_front() else {
-                            self.stop_stream().await;
-                            return;
-                        };
+                    let Some(song) = self.song_queue.lock().await.pop_front() else {
+                        self.stop_stream().await;
+                        return;
+                    };
                     song
                 }
             },
@@ -174,20 +172,21 @@ impl Player {
             },
         };
 
-        let mut call = call_mutex.lock().await;
-        _ = call
+        call_mutex
+            .lock()
+            .await
             .play_source(source)
             .add_event(Event::Track(TrackEvent::End), SongEnd {
                 guild_id: self.guild_id,
-            });
+            })
+            .ok();
         *self.now_playing.lock().await = Some(next_song);
     }
 
     /// Stops all playing songs.
     pub async fn stop_stream(&self) {
         if let Some(call_mutex) = get_call_mutex!(self.guild_id) {
-            let mut call = call_mutex.lock().await;
-            call.stop();
+            call_mutex.lock().await.stop();
             *self.now_playing.lock().await = None;
         }
     }
@@ -299,12 +298,13 @@ impl Player {
         let song_str = song.to_string();
 
         if selected {
-            _ = writeln!(
+            writeln!(
                 s,
                 "**{selected_char}{selected_whitespace}{number_style}{song_str}**"
-            );
+            )
+            .ok();
         } else {
-            _ = writeln!(s, "{normal_whitespace}{number_style}{song_str}");
+            writeln!(s, "{normal_whitespace}{number_style}{song_str}").ok();
         }
     }