fix: correct type for ad annotation #1822
Draft
+43
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Nov 3, 2025
src/Enzyme.jl
Outdated
| mode::CMode, f::FA, args::Vararg{Annotation,Nargs} | ||
| ) where {CMode<:Mode,FA<:Annotation,Nargs} | ||
| # need to guess the correct activity here. Execute the function, we will DCE it | ||
| res = call_with_reactant(f.val, [x.val for x in args]...) |
Member
There was a problem hiding this comment.
er, not always -- if f mutates this is wrong
Member
There was a problem hiding this comment.
the slightly more ideal case would be calling like https://github.com/EnzymeAD/Enzyme.jl/blob/bc031934aa2deefdcd3be139e4ad9a28e3692d14/src/typeutils/inference.jl#L73, except with our interpreter
avik-pal
force-pushed
the
ap/fix_enzyme_lowering_mlir
branch
from
3eeb45d to
072cc89
Compare
avik-pal
added a commit
to LuxDL/Lux.jl
that referenced
this pull request
Nov 3, 2025
avik-pal
force-pushed
the
ap/fix_enzyme_lowering_mlir
branch
2 times, most recently
from
58275d7 to
be74bb5
Compare
avik-pal
force-pushed
the
ap/fix_enzyme_lowering_mlir
branch
from
be74bb5 to
5ab6391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1821