feat: add degree-based wrappers for TracedRNumber (#1814)

* Add degree-based wrappers for TracedRNumber

* test: new trig functions

* Update test/basic.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Sid <siddhartha.bishnu@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: 3 people

src/TracedRNumber.jl

@@ -505,6 +505,27 @@ for (jlop, hloop) in (
     @eval $(jlop)(@nospecialize(lhs::TracedRNumber)) = @opcall $(hloop)(lhs)
 end
 
+# Degree-based trigonometric wrappers for TracedRNumber
+# These convert to radians internally so Reactant can lower to
+# StableHLO-supported radian trigonometric operations.
+
+Base.sind(x::TracedRNumber) = sin(deg2rad(x))
+Base.cosd(x::TracedRNumber) = cos(deg2rad(x))
+Base.tand(x::TracedRNumber) = tan(deg2rad(x))
+Base.cscd(x::TracedRNumber) = 1 / sind(x)
+Base.secd(x::TracedRNumber) = 1 / cosd(x)
+Base.cotd(x::TracedRNumber) = 1 / tand(x)
+
+Base.asind(x::TracedRNumber) = rad2deg(asin(x))
+Base.acosd(x::TracedRNumber) = rad2deg(acos(x))
+Base.atand(x::TracedRNumber) = rad2deg(atan(x))
+
+Base.atand(y::TracedRNumber, x::TracedRNumber) = rad2deg(atan(y, x))
+
+Base.acscd(x::TracedRNumber) = rad2deg(asin(1 / x))
+Base.asecd(x::TracedRNumber) = rad2deg(acos(1 / x))
+Base.acotd(x::TracedRNumber) = rad2deg(atan(1 / x))
+
 for (jlop, hloop) in (
     (:(Base.sin), :sine),
     (:(Base.cos), :cosine),

test/basic.jl

@@ -754,13 +754,46 @@ end
         @test @jit(fn.(x_ra)) isa ConcreteRArray{Float32,2}
     end
 
+    x2 = inv.(x)
+    x2_ra = Reactant.to_rarray(x2)
+
+    @testset for fn in (acscd, asecd)
+        @test @jit(fn.(x2_ra)) ≈ fn.(x2)
+        @test @jit(fn.(x2_ra)) isa ConcreteRArray{Float32,2}
+    end
+
+    xrad = deg2rad.(x)
+    xrad_ra = Reactant.to_rarray(xrad)
+
+    @testset for fn in (sind, cosd, tand, cscd, secd, cotd, asind, acosd, atand, acotd)
+        @test @jit(fn.(xrad_ra)) ≈ fn.(xrad)
+        @test @jit(fn.(xrad_ra)) isa ConcreteRArray{Float32,2}
+    end
+
     x = 0.235f0
     x_ra = Reactant.to_rarray(x; track_numbers=Number)
 
-    @testset for fn in (sinpi, cospi, tanpi, sin, cos, tan)
+    @testset for fn in (sinpi, cospi, tanpi, sin, cos, tan, asind, acosd, atand, acotd)
         @test @jit(fn.(x_ra)) ≈ fn.(x)
         @test @jit(fn.(x_ra)) isa ConcreteRNumber{Float32}
     end
+
+    x2 = inv(x)
+    x2_ra = Reactant.to_rarray(x2; track_numbers=Number)
+
+    @testset for fn in (acscd, asecd)
+        @test @jit(fn.(x2_ra)) ≈ fn.(x2)
+        @test @jit(fn.(x2_ra)) isa ConcreteRNumber{Float32}
+    end
+
+    xrad = deg2rad(x)
+    xrad_ra = Reactant.to_rarray(xrad; track_numbers=Number)
+
+    @testset for fn in (sind, cosd, tand, cscd, secd, cotd)
+        @test @jit(fn.(xrad_ra)) ≈ fn.(xrad)
+        @test @jit(fn.(xrad_ra)) isa ConcreteRNumber{Float32}
+    end
+
     @testset for fn in (sincospi, sincos)
         res = @jit fn(x_ra)
         @test res[1] ≈ fn(x)[1]