fix

Author: wsmoses

deps/ReactantExtra/.bazelrc

@@ -29,32 +29,32 @@ build --repo_env=RULES_PYTHON_ENABLE_PYSTAR=0
 
 build -c opt
 
-build:cuda --repo_env TF_NEED_CUDA=1
-build:cuda --repo_env TF_NVCC_CLANG=1
-build:cuda --repo_env TF_NCCL_USE_STUB=1
-build:cuda --repo_env=HERMETIC_CUDA_VERSION="12.8.1"
-build:cuda --repo_env=HERMETIC_CUDNN_VERSION="9.8.0"
-build:cuda --repo_env=HERMETIC_NVSHMEM_VERSION="3.2.5"
+common:cuda --repo_env TF_NEED_CUDA=1
+common:cuda --repo_env TF_NVCC_CLANG=1
+common:cuda --repo_env TF_NCCL_USE_STUB=1
+common:cuda --repo_env=HERMETIC_CUDA_VERSION="12.8.1"
+common:cuda --repo_env=HERMETIC_CUDNN_VERSION="9.8.0"
+common:cuda --repo_env=HERMETIC_NVSHMEM_VERSION="3.2.5"
 # "sm" means we emit only cubin, which is forward compatible within a GPU generation.
 # "compute" means we emit both cubin and PTX, which is larger but also forward compatible to future GPU generations.
-build:cuda --repo_env HERMETIC_CUDA_COMPUTE_CAPABILITIES="sm_60,sm_70,sm_80,compute_90"
-build:cuda --crosstool_top="@local_config_cuda//crosstool:toolchain"
-build:cuda --@local_config_cuda//:enable_cuda
+common:cuda --repo_env HERMETIC_CUDA_COMPUTE_CAPABILITIES="sm_60,sm_70,sm_80,compute_90"
+common:cuda --crosstool_top="@local_config_cuda//crosstool:toolchain"
+common:cuda --@local_config_cuda//:enable_cuda
 # Default hermetic CUDA and CUDNN versions.
-build:cuda --@local_config_cuda//cuda:include_cuda_libs=true
-build:cuda --@local_config_cuda//:cuda_compiler=nvcc
-# build:cuda --@local_config_nvshmem//:override_include_nvshmem_libs=true
-# build:cuda --@local_config_nvshmem//cuda:include_nvshmem_libs=true
+common:cuda --@local_config_cuda//cuda:include_cuda_libs=true
+common:cuda --@local_config_cuda//:cuda_compiler=nvcc
+# common:cuda --@local_config_nvshmem//:override_include_nvshmem_libs=true
+# common:cuda --@local_config_nvshmem//cuda:include_nvshmem_libs=true
 
 
-build:rocm --crosstool_top=@local_config_rocm//crosstool:toolchain
-build:rocm --define=using_rocm=true --define=using_rocm_hipcc=true
-build:rocm --repo_env TF_NEED_ROCM=1
-build:rocm --action_env TF_ROCM_AMDGPU_TARGETS="gfx900,gfx906,gfx908,gfx90a,gfx940,gfx941,gfx942,gfx1030,gfx1100,gfx1200,gfx1201"
+common:rocm --crosstool_top=@local_config_rocm//crosstool:toolchain
+common:rocm --define=using_rocm=true --define=using_rocm_hipcc=true
+common:rocm --repo_env TF_NEED_ROCM=1
+common:rocm --action_env TF_ROCM_AMDGPU_TARGETS="gfx900,gfx906,gfx908,gfx90a,gfx940,gfx941,gfx942,gfx1030,gfx1100,gfx1200,gfx1201"
 
 # Build with hipcc for ROCm and clang for the host.
-build:rocm --action_env=TF_ROCM_CLANG="1"
-build:rocm --action_env=CLANG_COMPILER_PATH="/usr/lib/llvm-18/bin/clang"
-build:rocm --copt=-Wno-gnu-offsetof-extensions
-build:rocm --copt=-Qunused-arguments
-build:rocm --action_env=TF_HIPCC_CLANG="1"
+common:rocm --action_env=TF_ROCM_CLANG="1"
+common:rocm --action_env=CLANG_COMPILER_PATH="/usr/lib/llvm-18/bin/clang"
+common:rocm --copt=-Wno-gnu-offsetof-extensions
+common:rocm --copt=-Qunused-arguments
+common:rocm --action_env=TF_HIPCC_CLANG="1"

deps/ReactantExtra/API.cpp

@@ -1626,8 +1626,9 @@ REACTANT_ABI HeldIfrtArray *ifrt_client_assemble_array_from_single_shards(
 REACTANT_ABI HeldIfrtArray *
 ifrt_pjrt_array_create(ifrt::PjRtClient *client,
                        HeldValue<std::shared_ptr<xla::PjRtBuffer>> *buffer) {
-  return reactant::capture(tsl::RCReference<ifrt::Array>(
-      MyValueOrThrow(xla::ifrt::PjRtArray::Create(client, buffer->obj()))));
+  return reactant::capture(
+      tsl::RCReference<ifrt::Array>(MyValueOrThrow(xla::ifrt::PjRtArray::Create(
+          client, buffer->obj(), /*has_custom_layout*/ false))));
 }
 
 // we might me interested in the `Compiler::Compile` method variant that accepts
@@ -2373,7 +2374,7 @@ REACTANT_ABI bool hlo_sharding_check_eq(xla::HloSharding *hloSharding,
 
 #pragma endregion
 
-typedef ifrt::Future<> IfRtFutureType;
+typedef tsl::Future<> IfRtFutureType;
 
 REACTANT_ABI void ifrt_free_future(IfRtFutureType *Future) { delete Future; }
 
@@ -2600,7 +2601,7 @@ REACTANT_ABI void ifrt_loaded_executable_execute(
   // there is only 1 status and is valid because we set `options.fill_status =
   // true`
   *futures = true;
-  *status = new FutureType(result.status);
+  *status = new IfRtFutureType(result.status);
 
   for (int i = 0; i < num_results; i++) {
     op_results[i] = reactant::capture(result.outputs[i]);

deps/ReactantExtra/WORKSPACE

@@ -3,7 +3,7 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 NSYNC_COMMIT = "82b118aa7ace3132e517e2c467f8732978cf4023"
 NSYNC_SHA256 = ""
 
-ENZYMEXLA_COMMIT = "96bcf384c5dce3341b347554c32bd02b2defc0eb"
+ENZYMEXLA_COMMIT = "f46d7016fbc50dc87125bbdfddf71ea6782073fd"
 ENZYMEXLA_SHA256 = ""
 
 http_archive(
@@ -34,7 +34,11 @@ LLVM_TARGETS = [
     "AArch64",
     "X86",
     "ARM",
-]
+] 
+#+ [
+#    "PowerPC",
+#    "SystemZ"
+#]
 
 # Uncomment these lines to use a custom LLVM commit
 # LLVM_COMMIT = "b39c5cb6977f35ad727d86b2dd6232099734ffd3"