sizeof() is an alias of count()

Author: staabm

src/Analyser/TypeSpecifier.php

@@ -206,7 +206,7 @@ public function specifyTypesInCondition(
 					&& $exprNode instanceof FuncCall
 					&& count($exprNode->args) === 1
 					&& $exprNode->name instanceof Name
-					&& strtolower((string) $exprNode->name) === 'count'
+					&& in_array(strtolower((string) $exprNode->name), ['count', 'sizeof'], true)
 					&& $constantType instanceof ConstantIntegerType
 				) {
 					if ($context->truthy() || $constantType->getValue() === 0) {

src/Rules/Comparison/ImpossibleCheckTypeHelper.php

@@ -78,7 +78,7 @@ public function findSpecifiedType(
 				], true)) {
 					return null;
 				}
-				if ($functionName === 'count') {
+				if (in_array($functionName, ['count', 'sizeof'], true)) {
 					return null;
 				} elseif ($functionName === 'defined') {
 					return null;

src/Type/Php/CountFunctionReturnTypeExtension.php

@@ -17,7 +17,7 @@ class CountFunctionReturnTypeExtension implements \PHPStan\Type\DynamicFunctionR
 
 	public function isFunctionSupported(FunctionReflection $functionReflection): bool
 	{
-		return $functionReflection->getName() === 'count';
+		return in_array($functionReflection->getName(), ['sizeof', 'count'], true);
 	}
 
 	public function getTypeFromFunctionCall(

src/Type/Php/CountFunctionTypeSpecifyingExtension.php

@@ -27,7 +27,7 @@ public function isFunctionSupported(
 	{
 		return !$context->null()
 			&& count($node->args) >= 1
-			&& $functionReflection->getName() === 'count';
+			&& in_array($functionReflection->getName(), ['sizeof', 'count'], true);
 	}
 
 	public function specifyTypes(

tests/PHPStan/Analyser/TypeSpecifierTest.php

@@ -584,6 +584,28 @@ public function dataCondition(): array
 					'$array' => 'nonEmpty',
 				],
 			],
+			[
+				new FuncCall(new Name('sizeof'), [
+					new Arg(new Variable('array')),
+				]),
+				[
+					'$array' => 'nonEmpty',
+				],
+				[
+					'$array' => '~nonEmpty',
+				],
+			],
+			[
+				new BooleanNot(new FuncCall(new Name('sizeof'), [
+					new Arg(new Variable('array')),
+				])),
+				[
+					'$array' => '~nonEmpty',
+				],
+				[
+					'$array' => 'nonEmpty',
+				],
+			],
 			[
 				new Variable('foo'),
 				[

tests/PHPStan/Analyser/data/count-type.php

@@ -15,6 +15,7 @@ public function doFoo(
 	)
 	{
 		assertType('int<1, max>', count($nonEmpty));
+		assertType('int<1, max>', sizeof($nonEmpty));
 	}
 
 }

tests/PHPStan/Rules/Variables/DefinedVariableRuleTest.php

@@ -452,27 +452,27 @@ public function testForeach(): void
 			],
 			[
 				'Undefined variable: $val',
-				171,
+				200,
 			],
 			[
 				'Undefined variable: $test',
-				172,
+				201,
 			],
 			[
 				'Undefined variable: $val',
-				187,
+				216,
 			],
 			[
 				'Undefined variable: $test',
-				188,
+				217,
 			],
 			[
 				'Variable $val might not be defined.',
-				217,
+				246,
 			],
 			[
 				'Variable $test might not be defined.',
-				218,
+				247,
 			],
 		]);
 	}

tests/PHPStan/Rules/Variables/data/foreach.php

@@ -107,6 +107,35 @@ function (array $arr) {
 
 };
 
+function (array $arr) {
+
+	if (sizeof($arr) === 0) {
+		return;
+	}
+
+	foreach ($arr as $val) {
+		$test = 1;
+	}
+
+	echo $val;
+	echo $test;
+
+};
+
+function (array $arr) {
+
+	if (sizeof($arr) === 0) {
+		return;
+	}
+
+	if ($arr) {
+		$test = 1;
+	}
+
+	echo $test;
+
+};
+
 /*function (array $arr) {
 
 	if (count($arr) > 0) {