Allow destructuring of objects implementing ArrayAccess

Author: herndlm

src/Rules/Arrays/ArrayDestructuringRule.php

@@ -14,6 +14,7 @@
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\ErrorType;
+use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 
@@ -65,14 +66,14 @@ private function getErrors(Scope $scope, Expr $var, Expr $expr): array
 			$expr,
 			'',
 			static function (Type $varType): bool {
-				return $varType->isArray()->yes();
+				return $varType->isArray()->yes() || (new ObjectType(\ArrayAccess::class))->isSuperTypeOf($varType)->yes();
 			}
 		);
 		$exprType = $exprTypeResult->getType();
 		if ($exprType instanceof ErrorType) {
 			return [];
 		}
-		if (!$exprType->isArray()->yes()) {
+		if (!$exprType->isArray()->yes() && !(new ObjectType(\ArrayAccess::class))->isSuperTypeOf($exprType)->yes()) {
 			return [
 				RuleErrorBuilder::message(sprintf('Cannot use array destructuring on %s.', $exprType->describe(VerbosityLevel::typeOnly())))->build(),
 			];

tests/PHPStan/Rules/Arrays/data/array-destructuring.php

@@ -22,4 +22,33 @@ public function doBar(): void
 		['a' => $a] = ['b' => 1];
 	}
 
+	public function doBaz(): void
+	{
+		$arrayObject = new FooArrayObject();
+		['a' => $a] = $arrayObject;
+	}
+
+}
+
+class FooArrayObject implements \ArrayAccess
+{
+
+	public function offsetGet($key)
+	{
+		return true;
+	}
+
+	public function offsetSet($key, $value): void
+	{
+	}
+
+	public function offsetUnset($key): void
+	{
+	}
+
+	public function offsetExists($key): bool
+	{
+		return false;
+	}
+
 }