TypeCombinatorTest - use yield from to add conditional test cases later

ondrejmirtes · ondrejmirtes · commit e7faf08313db · 2021-12-20T21:30:09.000+01:00
diff --git a/tests/PHPStan/Type/TypeCombinatorTest.php b/tests/PHPStan/Type/TypeCombinatorTest.php
@@ -242,9 +242,9 @@ public function testRemoveNull(
 		$this->assertInstanceOf($expectedTypeClass, $result);
 	}
 
-	public function dataUnion(): array
+	public function dataUnion(): iterable
 	{
-		return [
+		yield from [
 			[
 				[
 					new StringType(),
@@ -1959,11 +1959,11 @@ public function testUnionInversed(
 		$this->assertInstanceOf($expectedTypeClass, $actualType);
 	}
 
-	public function dataIntersect(): array
+	public function dataIntersect(): iterable
 	{
 		$reflectionProvider = $this->createReflectionProvider();
 
-		return [
+		yield from [
 			[
 				[
 					new IterableType(new MixedType(), new StringType()),

Original file line number	Diff line number	Diff line change
`@@ -242,9 +242,9 @@ public function testRemoveNull(`
`242`	`242`	`$this->assertInstanceOf($expectedTypeClass, $result);`
`243`	`243`	`}`
`244`	`244`
`245`		`- public function dataUnion(): array`
	`245`	`+ public function dataUnion(): iterable`
`246`	`246`	`{`
`247`		`- return [`
	`247`	`+ yield from [`
`248`	`248`	`[`
`249`	`249`	`[`
`250`	`250`	`new StringType(),`
`@@ -1959,11 +1959,11 @@ public function testUnionInversed(`
`1959`	`1959`	`$this->assertInstanceOf($expectedTypeClass, $actualType);`
`1960`	`1960`	`}`
`1961`	`1961`
`1962`		`- public function dataIntersect(): array`
	`1962`	`+ public function dataIntersect(): iterable`
`1963`	`1963`	`{`
`1964`	`1964`	`$reflectionProvider = $this->createReflectionProvider();`
`1965`	`1965`
`1966`		`- return [`
	`1966`	`+ yield from [`
`1967`	`1967`	`[`
`1968`	`1968`	`[`
`1969`	`1969`	`new IterableType(new MixedType(), new StringType()),`