faster TypeCombinator::remove()

voku · ondrejmirtes · commit c61763d7e56a · 2021-10-28T14:17:01.000+02:00
diff --git a/src/Type/TypeCombinator.php b/src/Type/TypeCombinator.php
@@ -95,7 +95,7 @@ public static function remove(Type $fromType, Type $typeToRemove): Type
 				$lowerPart = $removeValueMin !== null ? IntegerRangeType::fromInterval(null, $removeValueMin, -1) : null;
 				$upperPart = $removeValueMax !== null ? IntegerRangeType::fromInterval($removeValueMax, null, +1) : null;
 				if ($lowerPart !== null && $upperPart !== null) {
-					return self::union($lowerPart, $upperPart);
+					return new UnionType([$lowerPart, $upperPart]);
 				}
 				return $lowerPart ?? $upperPart ?? new NeverType();
 			}

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public static function remove(Type $fromType, Type $typeToRemove): Type`
`95`	`95`	`$lowerPart = $removeValueMin !== null ? IntegerRangeType::fromInterval(null, $removeValueMin, -1) : null;`
`96`	`96`	`$upperPart = $removeValueMax !== null ? IntegerRangeType::fromInterval($removeValueMax, null, +1) : null;`
`97`	`97`	`if ($lowerPart !== null && $upperPart !== null) {`
`98`		`- return self::union($lowerPart, $upperPart);`
	`98`	`+ return new UnionType([$lowerPart, $upperPart]);`
`99`	`99`	`}`
`100`	`100`	`return $lowerPart ?? $upperPart ?? new NeverType();`
`101`	`101`	`}`