Added EnumCaseAttributesRule

Author: kukulich

src/Rules/EnumCases/EnumCaseAttributesRule.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\EnumCases;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Rules\AttributesCheck;
+use PHPStan\Rules\Rule;
+
+/**
+ * @implements Rule<Node\Stmt\EnumCase>
+ */
+class EnumCaseAttributesRule implements Rule
+{
+
+	private AttributesCheck $attributesCheck;
+
+	public function __construct(AttributesCheck $attributesCheck)
+	{
+		$this->attributesCheck = $attributesCheck;
+	}
+
+	public function getNodeType(): string
+	{
+		return Node\Stmt\EnumCase::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		return $this->attributesCheck->check(
+			$scope,
+			$node->attrGroups,
+			\Attribute::TARGET_CLASS_CONSTANT,
+			'class constant'
+		);
+	}
+
+}

tests/PHPStan/Rules/EnumCases/EnumCaseAttributesRuleTest.php

@@ -0,0 +1,56 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\EnumCases;
+
+use PHPStan\Php\PhpVersion;
+use PHPStan\Rules\AttributesCheck;
+use PHPStan\Rules\ClassCaseSensitivityCheck;
+use PHPStan\Rules\FunctionCallParametersCheck;
+use PHPStan\Rules\NullsafeCheck;
+use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleLevelHelper;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<EnumCaseAttributesRule>
+ */
+class EnumCaseAttributesRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		$reflectionProvider = $this->createReflectionProvider();
+		return new EnumCaseAttributesRule(
+			new AttributesCheck(
+				$reflectionProvider,
+				new FunctionCallParametersCheck(
+					new RuleLevelHelper($reflectionProvider, true, false, true, false),
+					new NullsafeCheck(),
+					new PhpVersion(80100),
+					new UnresolvableTypeHelper(),
+					true,
+					true,
+					true,
+					true
+				),
+				new ClassCaseSensitivityCheck($reflectionProvider, false)
+			)
+		);
+	}
+
+	public function testRule(): void
+	{
+		if (!self::$useStaticReflectionProvider && PHP_VERSION_ID < 80100) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
+		}
+
+		$this->analyse([__DIR__ . '/data/enum-case-attributes.php'], [
+			[
+				'Attribute class EnumCaseAttributes\AttributeWithPropertyTarget does not have the class constant target.',
+				26,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/EnumCases/data/enum-case-attributes.php

@@ -0,0 +1,45 @@
+<?php // lint >= 8.1
+
+namespace EnumCaseAttributes;
+
+#[\Attribute(\Attribute::TARGET_PROPERTY)]
+class AttributeWithPropertyTarget
+{
+
+}
+
+#[\Attribute(\Attribute::TARGET_CLASS_CONSTANT)]
+class AttributeWithClassConstantTarget
+{
+
+}
+
+#[\Attribute(\Attribute::TARGET_ALL)]
+class AttributeWithTargetAll
+{
+
+}
+
+enum Lorem
+{
+
+	#[AttributeWithPropertyTarget]
+	case FOO;
+
+}
+
+enum Ipsum
+{
+
+	#[AttributeWithClassConstantTarget]
+	case FOO;
+
+}
+
+enum Dolor
+{
+
+	#[AttributeWithTargetAll]
+	case FOO;
+
+}