Cache constant reflections

Author: ondrejmirtes

src/Reflection/BetterReflection/BetterReflectionProvider.php

@@ -82,6 +82,9 @@ class BetterReflectionProvider implements ReflectionProvider
 	/** @var \PHPStan\Reflection\ClassReflection[] */
 	private static array $anonymousClasses = [];
 
+	/** @var array<string, GlobalConstantReflection> */
+	private array $cachedConstants = [];
+
 	public function __construct(
 		ReflectionProvider\ReflectionProviderProvider $reflectionProviderProvider,
 		ClassReflectionExtensionRegistryProvider $classReflectionExtensionRegistryProvider,
@@ -359,6 +362,10 @@ public function getConstant(\PhpParser\Node\Name $nameNode, ?Scope $scope): Glob
 			throw new \PHPStan\Broker\ConstantNotFoundException((string) $nameNode);
 		}
 
+		if (array_key_exists($constantName, $this->cachedConstants)) {
+			return $this->cachedConstants[$constantName];
+		}
+
 		$constantReflection = $this->constantReflector->reflect($constantName);
 		try {
 			$constantValue = $constantReflection->getValue();
@@ -369,7 +376,7 @@ public function getConstant(\PhpParser\Node\Name $nameNode, ?Scope $scope): Glob
 			$fileName = null;
 		}
 
-		return new RuntimeConstantReflection(
+		return $this->cachedConstants[$constantName] = new RuntimeConstantReflection(
 			$constantName,
 			$constantValueType,
 			$fileName

src/Reflection/Runtime/RuntimeReflectionProvider.php

@@ -59,6 +59,9 @@ class RuntimeReflectionProvider implements ReflectionProvider
 	/** @var \PHPStan\Reflection\ClassReflection[] */
 	private static array $anonymousClasses = [];
 
+	/** @var array<string, GlobalConstantReflection> */
+	private array $cachedConstants = [];
+
 	public function __construct(
 		ReflectionProvider\ReflectionProviderProvider $reflectionProviderProvider,
 		ClassReflectionExtensionRegistryProvider $classReflectionExtensionRegistryProvider,
@@ -341,7 +344,11 @@ public function getConstant(\PhpParser\Node\Name $nameNode, ?Scope $scope): Glob
 			throw new \PHPStan\Broker\ConstantNotFoundException((string) $nameNode);
 		}
 
-		return new RuntimeConstantReflection(
+		if (array_key_exists($constantName, $this->cachedConstants)) {
+			return $this->cachedConstants[$constantName];
+		}
+
+		return $this->cachedConstants[$constantName] = new RuntimeConstantReflection(
 			$constantName,
 			ConstantTypeHelper::getTypeFromValue(constant($constantName)),
 			null