Do not cache ClassReflection in ObjectType, such object cannot be dumped to cache

Author: ondrejmirtes

src/Analyser/MutatingScope.php

@@ -2146,7 +2146,7 @@ private function resolveType(Expr $node): Type
 				}
 
 				if ($constantClassReflection->isEnum() && $constantClassReflection->hasEnumCase($constantName)) {
-					$types[] = new EnumCaseObjectType($constantClassReflection->getName(), $constantName, $constantClassReflection);
+					$types[] = new EnumCaseObjectType($constantClassReflection->getName(), $constantName);
 					continue;
 				}
 

src/PhpDoc/TypeNodeResolver.php

@@ -740,7 +740,7 @@ private function resolveConstTypeNode(ConstTypeNode $typeNode, NameScope $nameSc
 					}
 
 					if ($classReflection->isEnum() && $classReflection->hasEnumCase($classConstantName)) {
-						$constantTypes[] = new EnumCaseObjectType($classReflection->getName(), $classConstantName, $classReflection);
+						$constantTypes[] = new EnumCaseObjectType($classReflection->getName(), $classConstantName);
 						continue;
 					}
 
@@ -759,7 +759,7 @@ private function resolveConstTypeNode(ConstTypeNode $typeNode, NameScope $nameSc
 			}
 
 			if ($classReflection->isEnum() && $classReflection->hasEnumCase($constantName)) {
-				return new EnumCaseObjectType($classReflection->getName(), $constantName, $classReflection);
+				return new EnumCaseObjectType($classReflection->getName(), $constantName);
 			}
 
 			return ConstantTypeHelper::getTypeFromValue($classReflection->getConstant($constantName)->getValue());

src/Type/ObjectType.php

@@ -1046,32 +1046,32 @@ public function getNakedClassReflection(): ?ClassReflection
 		if ($this->classReflection !== null) {
 			return $this->classReflection;
 		}
+
 		$reflectionProvider = ReflectionProviderStaticAccessor::getInstance();
 		if (!$reflectionProvider->hasClass($this->className)) {
 			return null;
 		}
 
-		$this->classReflection = $reflectionProvider->getClass($this->className);
-
-		return $this->classReflection;
+		return $reflectionProvider->getClass($this->className);
 	}
 
 	public function getClassReflection(): ?ClassReflection
 	{
 		if ($this->classReflection !== null) {
 			return $this->classReflection;
 		}
+
 		$reflectionProvider = ReflectionProviderStaticAccessor::getInstance();
 		if (!$reflectionProvider->hasClass($this->className)) {
 			return null;
 		}
 
 		$classReflection = $reflectionProvider->getClass($this->className);
 		if ($classReflection->isGeneric()) {
-			return $this->classReflection = $classReflection->withTypes(array_values($classReflection->getTemplateTypeMap()->resolveToBounds()->getTypes()));
+			return $classReflection->withTypes(array_values($classReflection->getTemplateTypeMap()->resolveToBounds()->getTypes()));
 		}
 
-		return $this->classReflection = $classReflection;
+		return $classReflection;
 	}
 
 	/**