fixed a bug that could cause directives to be built with synthetic fields

osher-sade · osher-sade · commit f9a83d04f36c · 2019-07-09T12:34:08.000+03:00
diff --git a/src/main/java/graphql/annotations/processor/directives/DirectiveCreator.java b/src/main/java/graphql/annotations/processor/directives/DirectiveCreator.java
@@ -49,11 +49,9 @@ public GraphQLDirective getDirective(Class<?> annotatedClass) {
     }
 
     private void buildArguments(GraphQLDirective.Builder builder, Class<?> annotatedClass) {
-        Arrays.stream(annotatedClass.getDeclaredFields()).forEach(x -> {
-            if (!x.isSynthetic()) {
-                builder.argument(directiveArgumentCreator.getArgument(x, annotatedClass));
-            }
-        });
+        Arrays.stream(annotatedClass.getDeclaredFields())
+                .filter(x -> !x.isSynthetic())
+                .forEach(x -> builder.argument(directiveArgumentCreator.getArgument(x, annotatedClass)));
     }
 
     private Introspection.DirectiveLocation[] getValidLocations(Class<?> annotatedClass) {

Original file line number	Diff line number	Diff line change
`@@ -49,11 +49,9 @@ public GraphQLDirective getDirective(Class<?> annotatedClass) {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`private void buildArguments(GraphQLDirective.Builder builder, Class<?> annotatedClass) {`
`52`		`- Arrays.stream(annotatedClass.getDeclaredFields()).forEach(x -> {`
`53`		`- if (!x.isSynthetic()) {`
`54`		`- builder.argument(directiveArgumentCreator.getArgument(x, annotatedClass));`
`55`		`- }`
`56`		`- });`
	`52`	`+ Arrays.stream(annotatedClass.getDeclaredFields())`
	`53`	`+ .filter(x -> !x.isSynthetic())`
	`54`	`+ .forEach(x -> builder.argument(directiveArgumentCreator.getArgument(x, annotatedClass)));`
`57`	`55`	`}`
`58`	`56`
`59`	`57`	`private Introspection.DirectiveLocation[] getValidLocations(Class<?> annotatedClass) {`