Skip to content

Commit ea31cb2

Browse files
authored
Merge pull request #170 from yarinvak/check-float
remove float support from floatfunction - only doubles are allowed
2 parents 5dddce5 + 72a105e commit ea31cb2

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/main/java/graphql/annotations/processor/typeFunctions/FloatFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public String getTypeName(Class<?> aClass, AnnotatedType annotatedType) {
2929

3030
@Override
3131
public boolean canBuildType(Class<?> aClass, AnnotatedType annotatedType) {
32-
return aClass == Float.class || aClass == float.class || aClass == Double.class || aClass == double.class;
32+
return aClass == Double.class || aClass == double.class;
3333
}
3434

3535
@Override

src/test/java/graphql/annotations/GraphQLObjectTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ public String getZ() {
125125
public void setZ(String z) {
126126
this.z = z;
127127
}
128+
128129
}
129130

130131
private static class TestDefaults {
@@ -825,6 +826,7 @@ public String getOn() {
825826
public String getOff() {
826827
return "off";
827828
}
829+
828830
}
829831

830832
@Test
@@ -836,4 +838,5 @@ public void inheritGraphQLField() {
836838
assertNull(object.getFieldDefinition("forcedOff"));
837839
}
838840

841+
839842
}

src/test/java/graphql/annotations/processor/typeFunctions/FloatFunctionTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ public void init() {
3232
@Test
3333
public void buildType_floatType_returnsGraphQLFloat() {
3434
DefaultTypeFunction instance = testedDefaultTypeFunction();
35-
assertEquals(instance.buildType(float.class, null,null), GraphQLFloat);
36-
assertEquals(instance.buildType(Float.class, null,null), GraphQLFloat);
3735
assertEquals(instance.buildType(Double.class, null,null), GraphQLFloat);
3836
assertEquals(instance.buildType(double.class, null,null), GraphQLFloat);
3937
}

0 commit comments

Comments
 (0)