Skip to content

Commit 5189d2b

Browse files
committed
remove float support from floatfunction - only doubles are allowed
1 parent a790187 commit 5189d2b

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

src/main/java/graphql/annotations/processor/typeFunctions/FloatFunction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public String getTypeName(Class<?> aClass, AnnotatedType annotatedType) {
2929

3030
@Override
3131
public boolean canBuildType(Class<?> aClass, AnnotatedType annotatedType) {
32-
return aClass == Float.class || aClass == float.class || aClass == Double.class || aClass == double.class;
32+
return aClass == Double.class || aClass == double.class;
3333
}
3434

3535
@Override

src/test/java/graphql/annotations/GraphQLObjectTest.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,12 @@ public String getZ() {
125125
public void setZ(String z) {
126126
this.z = z;
127127
}
128+
129+
@GraphQLField
130+
@GraphQLInvokeDetached
131+
public Integer doubleToInt(@GraphQLNonNull @GraphQLName("data") Double data) {
132+
return data.intValue();
133+
}
128134
}
129135

130136
private static class TestDefaults {
@@ -173,6 +179,17 @@ public TestObjectDB get(DataFetchingEnvironment environment) {
173179
}
174180
}
175181

182+
@Test
183+
public void doubleIntQuery() {
184+
GraphQLSchema schema = newSchema().query(GraphQLAnnotations.object(TestObject.class)).build();
185+
GraphQL graphQL = GraphQL.newGraphQL(schema).build();
186+
ExecutionResult result = graphQL.execute("{ doubleToInt ( data:15.0 ) }");
187+
assertTrue(result.getErrors().isEmpty());
188+
assertEquals(((Map<String, Integer>) result.getData()).get("doubleToInt"), Integer.valueOf(15));
189+
}
190+
191+
192+
176193
@Test
177194
public void fetchTestMappedObject_assertNameIsMappedFromDBObject(){
178195
GraphQLObjectType object = GraphQLAnnotations.object(TestQuery.class);
@@ -825,6 +842,7 @@ public String getOn() {
825842
public String getOff() {
826843
return "off";
827844
}
845+
828846
}
829847

830848
@Test
@@ -836,4 +854,5 @@ public void inheritGraphQLField() {
836854
assertNull(object.getFieldDefinition("forcedOff"));
837855
}
838856

857+
839858
}

0 commit comments

Comments
 (0)