Merge remote-tracking branch 'origin/ruslan/add-mint-and-metadata' into feature/change-transactionbuilder-creation

# Conflicts:
#	rust/src/tx_builder.rs

Author: vsubhuman

.github/workflows/pr-checks.yml

@@ -41,3 +41,30 @@ jobs:
       - name: rust:build-browser
         run: |
           npm run rust:build-browser
+  check-warns:
+    if: github.event.review && (github.event.review.state == 'approved' || contains(github.event.review.body, '/check'))
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: 'recursive'
+      - uses: actions/setup-node@v1
+        with:
+          node-version: '12.18.1'
+      - name: Cache node modules
+        uses: actions/cache@v1
+        with:
+          path: ~/.npm # npm cache files are stored in `~/.npm` on Linux/macOS
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-build-${{ env.cache-name }}-
+            ${{ runner.os }}-build-
+            ${{ runner.os }}-
+      - name: prepare-rust
+        run: |
+          rustup install stable
+          rustup target add wasm32-unknown-unknown --toolchain stable
+          curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
+      - name: rust:check-warnings
+        run: |
+          npm run rust:check-warnings

package.json

@@ -9,6 +9,7 @@
     "rust:build-asm": "(rimraf ./rust/pkg && cd rust; wasm-pack build --target=browser; wasm-pack pack) && npm run asm:build && npm run js:flowgen",
     "rust:publish": "cd rust && cargo publish && cd ../",
     "asm:build": "./binaryen/bin/wasm2js ./rust/pkg/cardano_serialization_lib_bg.wasm --output ./rust/pkg/cardano_serialization_lib.asm.js && node ./scripts/wasm-to-asm",
+    "rust:check-warnings": "(cd rust; RUSTFLAGS=\"-D warnings\" cargo +stable build)",
     "rust:test": "(cd rust; cargo test)",
     "js:flowgen": "flowgen ./rust/pkg/cardano_serialization_lib.d.ts -o ./rust/pkg/cardano_serialization_lib.js.flow --add-flow-header",
     "js:prepublish": "npm run rust:test && rimraf ./publish && cp -r ./rust/pkg ./publish && cp README.md publish/ && cp LICENSE publish/",

rust/pkg/cardano_serialization_lib.js.flow

@@ -2465,14 +2465,16 @@ declare export class Mint {
   keys(): ScriptHashes;
 
   /**
+   * Returns the multiasset where only positive (minting) entries are present
    * @returns {MultiAsset}
    */
-  to_multiasset(): MultiAsset;
+  as_positive_multiasset(): MultiAsset;
 
   /**
-   * @returns {Value}
+   * Returns the multiasset where only negative (burning) entries are present
+   * @returns {MultiAsset}
    */
-  to_value(): Value;
+  as_negative_multiasset(): MultiAsset;
 }
 /**
  */
@@ -5126,6 +5128,11 @@ declare export class TransactionBuilder {
    */
   set_withdrawals(withdrawals: Withdrawals): void;
 
+  /**
+   * @returns {AuxiliaryData | void}
+   */
+  get_auxiliary_data(): AuxiliaryData | void;
+
   /**
    * Set explicit auxiliary data via an AuxiliaryData object
    * It might contain some metadata plus native or Plutus scripts
@@ -5273,12 +5280,6 @@ declare export class TransactionBuilder {
    */
   get_implicit_input(): Value;
 
-  /**
-   * mint as value
-   * @returns {Value}
-   */
-  get_mint_value(): Value;
-
   /**
    * does not include fee
    * @returns {Value}
@@ -5316,10 +5317,21 @@ declare export class TransactionBuilder {
   output_sizes(): Uint32Array;
 
   /**
+   * Returns object the body of the new transaction
+   * Auxiliary data itself is not included
+   * You can use `get_auxiliary_date` or `build_tx`
    * @returns {TransactionBody}
    */
   build(): TransactionBody;
 
+  /**
+   * Returns full Transaction object with the body and the auxiliary data
+   * NOTE: witness_set is set to just empty set
+   * NOTE: is_valid set to true
+   * @returns {Transaction}
+   */
+  build_tx(): Transaction;
+
   /**
    * warning: sum of all parts of a transaction must equal 0. You cannot just set the fee to the min value and forget about it
    * warning: min_fee may be slightly larger than the actual minimum fee (ex: a few lovelaces)
@@ -6006,6 +6018,12 @@ declare export class Value {
    */
   static new(coin: BigNum): Value;
 
+  /**
+   * @param {MultiAsset} multiasset
+   * @returns {Value}
+   */
+  static new_from_assets(multiasset: MultiAsset): Value;
+
   /**
    * @returns {Value}
    */

rust/src/address.rs

@@ -440,7 +440,7 @@ impl Address {
             None => {
                 // see CIP5 for bech32 prefix rules
                 let prefix_header = match &self.0 {
-                    AddrType::Reward(a) => "stake",
+                    AddrType::Reward(_) => "stake",
                     _ => "addr",
                 };
                 let prefix_tail = match self.network_id()? {

rust/src/crypto.rs

@@ -588,7 +588,7 @@ impl Deserialize for BootstrapWitness {
 }
 
 impl DeserializeEmbeddedGroup for BootstrapWitness {
-    fn deserialize_as_embedded_group<R: BufRead + Seek>(raw: &mut Deserializer<R>, len: cbor_event::Len) -> Result<Self, DeserializeError> {
+    fn deserialize_as_embedded_group<R: BufRead + Seek>(raw: &mut Deserializer<R>, _: cbor_event::Len) -> Result<Self, DeserializeError> {
         let vkey = (|| -> Result<_, DeserializeError> {
             Ok(Vkey::deserialize(raw)?)
         })().map_err(|e| e.annotate("vkey"))?;
@@ -953,7 +953,6 @@ impl cbor_event::se::Serialize for Nonce {
 
 impl Deserialize for Nonce {
     fn deserialize<R: std::io::BufRead>(raw: &mut Deserializer<R>) -> Result<Self, DeserializeError> {
-        use std::convert::TryInto;
         (|| -> Result<Self, DeserializeError> {
             let len = raw.array()?;
             let hash = match raw.unsigned_integer()? {

rust/src/error.rs

@@ -1,5 +1,4 @@
-use cbor_event::{self, de::Deserializer, se::{Serialize, Serializer}};
-use std::io::{BufRead, Seek, Write};
+use cbor_event::{self};
 use crate::chain_crypto;
 use super::*;