clippy: fix all lints in elementsd-test crate

Apparently `clippy --all-features --all-targets` doesn't actually do all
targets.

Author: apoelstra

elementsd-tests/src/lib.rs

@@ -10,6 +10,7 @@ use elementsd::bitcoind::{self, BitcoinD};
 use elementsd::ElementsD;
 use std::str::FromStr;
 
+#[allow(dead_code)]
 trait Call {
     fn call(&self, cmd: &str, args: &[Value]) -> Value;
     fn decode_psbt(&self, psbt: &str) -> Option<Value>;

elementsd-tests/src/pset.rs

@@ -57,7 +57,7 @@ fn tx_issuance() {
 
     let contract_hash = ContractHash::from_byte_array([0u8; 32]);
     let entropy = AssetId::generate_asset_entropy(prevout, contract_hash);
-    let asset_id = AssetId::from_entropy(entropy.clone());
+    let asset_id = AssetId::from_entropy(entropy);
     let reissuance_id = AssetId::reissuance_token_from_entropy(entropy, is_21);
 
     let value = elementsd.call(
@@ -140,7 +140,7 @@ fn rtt(base64: &str) -> String {
 
 fn psbt_rtt(elementsd: &ElementsD, base64: &str) {
     use bitcoin::base64::prelude::{Engine as _, BASE64_STANDARD};
-    let a = elementsd.decode_psbt(&base64).unwrap();
+    let a = elementsd.decode_psbt(base64).unwrap();
 
     let b_psbt: PartiallySignedTransaction = base64.parse().unwrap();
     let mut b_bytes = serialize(&b_psbt);

elementsd-tests/src/taproot.rs

@@ -69,7 +69,7 @@ fn funded_tap_txout(
 
     let (blind_sk, blind_pk) = if blind {
         let sk = secp256k1_zkp::SecretKey::new(&mut thread_rng());
-        let pk = secp256k1_zkp::PublicKey::from_secret_key(&secp, &sk);
+        let pk = secp256k1_zkp::PublicKey::from_secret_key(secp, &sk);
         (Some(sk), Some(pk))
     } else {
         (None, None)
@@ -149,7 +149,7 @@ fn taproot_spend_test(
     blind_tx: bool,
     key_spend: bool,
 ) {
-    let test_data = funded_tap_txout(&elementsd, &secp, blind_prevout);
+    let test_data = funded_tap_txout(elementsd, secp, blind_prevout);
 
     // create a new spend that spends the above output
     let mut tx = Transaction {
@@ -182,11 +182,11 @@ fn taproot_spend_test(
     if blind_tx {
         // set the nNonce as some confidential key to mark the output for blinding
         let sk = secp256k1_zkp::SecretKey::new(&mut thread_rng());
-        let pk = secp256k1_zkp::PublicKey::from_secret_key(&secp, &sk);
+        let pk = secp256k1_zkp::PublicKey::from_secret_key(secp, &sk);
         tx.output[0].nonce = confidential::Nonce::Confidential(pk);
         tx.blind(
             &mut thread_rng(),
-            &secp,
+            secp,
             &[test_data.txout_secrets],
             false
         )
@@ -216,11 +216,11 @@ fn taproot_spend_test(
         let tweak = secp256k1_zkp::Scalar::from_be_bytes(tweak.to_byte_array()).expect("hash value greater than curve order");
         let sig = secp.sign_schnorr(
             &secp256k1_zkp::Message::from_digest_slice(&sighash_msg[..]).unwrap(),
-            &output_keypair.add_xonly_tweak(&secp, &tweak).unwrap(),
+            &output_keypair.add_xonly_tweak(secp, &tweak).unwrap(),
         );
 
         let schnorr_sig = SchnorrSig {
-            sig: sig,
+            sig,
             hash_ty: sighash_ty,
         };
 
@@ -247,7 +247,7 @@ fn taproot_spend_test(
         let ctrl_block = test_data.spend_info.control_block(&script_ver).unwrap();
 
         let schnorr_sig = SchnorrSig {
-            sig: sig,
+            sig,
             hash_ty: sighash_ty,
         };