Skip to content

Commit 48ca8b0

Browse files
committed
test: fix bug in wallet_groups.py functional test that was introduced in merge of bitcoin/bitcoin#22364 in 00f2e32
1 parent ec4c2a4 commit 48ca8b0

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

test/functional/test_runner.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,8 @@
208208
'rpc_signrawtransaction.py --descriptors',
209209
'rpc_rawtransaction.py --legacy-wallet',
210210
'rpc_rawtransaction.py --descriptors',
211-
# ELEMENTS: FIXME failing tests
212-
# 'wallet_groups.py --legacy-wallet',
213-
# 'wallet_groups.py --descriptors',
211+
'wallet_groups.py --legacy-wallet',
212+
'wallet_groups.py --descriptors',
214213
'wallet_transactiontime_rescan.py --descriptors',
215214
'wallet_transactiontime_rescan.py --legacy-wallet',
216215
'p2p_addrv2_relay.py',

test/functional/wallet_groups.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,6 @@ def run_test(self):
6060
# one output should be 0.2, the other should be ~0.3
6161
v = [vout["value"] for vout in tx1["vout"] if vout["scriptPubKey"]["type"] != "fee"]
6262
v.sort()
63-
# JAMES/BYRON DELETE ME
64-
#print(self.nodes[1].listunspent())
65-
print("vin amount = {}".format(self.nodes[0].gettxout(tx1["vin"][0]["txid"], tx1["vin"][0]["vout"], True)["value"]))
66-
print("vout amounts = {}".format(v))
67-
# END JAMES?BYRON
6863
assert_approx(v[0], vexp=0.2, vspan=0.0001)
6964
assert_approx(v[1], vexp=0.3, vspan=0.0001)
7065

@@ -114,10 +109,10 @@ def run_test(self):
114109
assert_equal(input_addrs[0], input_addrs[1])
115110
# Node 2 enforces avoidpartialspends so needs no checking here
116111

117-
tx4_ungrouped_fee = 2820
118-
tx4_grouped_fee = 4160
119-
tx5_6_ungrouped_fee = 5520
120-
tx5_6_grouped_fee = 8240
112+
tx4_ungrouped_fee = 5140
113+
tx4_grouped_fee = 6520
114+
tx5_6_ungrouped_fee = 7880
115+
tx5_6_grouped_fee = 10620
121116

122117
self.log.info("Test wallet option maxapsfee")
123118
addr_aps = self.nodes[3].getnewaddress()

0 commit comments

Comments
 (0)