Skip to content

Commit b3bb3ce

Browse files
committed
fix build issues
1 parent e25b89f commit b3bb3ce

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

ElectronNET.CLI/Commands/BuildCommand.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,16 @@ public Task<bool> ExecuteAsync()
108108
Console.WriteLine("Start npm install electron-builder...");
109109

110110
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
111-
112111
{
113112
// Works proper on Windows...
114113
ProcessHelper.CmdExecute("npm install electron-builder --global", tempPath);
114+
115115
}
116116
else
117117
{
118118
// ToDo: find another solution or document it proper
119119
// GH Issue https://github.com/electron-userland/electron-prebuilt/issues/48
120-
Console.WriteLine("Electron Builder - make sure you invoke 'sudo npm install electron-builder --global' at " + tempPath + " manually. Sry.");
120+
Console.WriteLine("Electron Builder - make sure you invoke 'sudo npm install electron-builder --global' & 'sudo npm install typescript --global' at " + tempPath + " manually. Sry.");
121121
}
122122

123123
Console.WriteLine("ElectronHostHook handling started...");
@@ -130,6 +130,7 @@ public Task<bool> ExecuteAsync()
130130
DirectoryCopy.Do(electronhosthookDir, hosthookDir, true, new List<string>() { "node_modules" });
131131

132132
Console.WriteLine("Start npm install for hosthooks...");
133+
ProcessHelper.CmdExecute("npm install typescript --global", tempPath);
133134
ProcessHelper.CmdExecute("npm install --production", hosthookDir);
134135

135136
// ToDo: Global TypeScript installation is needed for ElectronHostHook

buildAll.cmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@ dotnet tool uninstall ElectronNET.CLI -g
2222
dotnet tool install ElectronNET.CLI -g
2323

2424
echo "/target xxx (dev-build)"
25-
electronize build /target custom win7-x86;win32 /dotnet-configuration Debug /electron-arch ia32 /electron-params "--prune=true "
25+
electronize build /target custom win7-x86;win /dotnet-configuration Debug /electron-arch ia32 /electron-params " "
2626

2727
echo "/target win (dev-build)"
2828
electronize build /target win
2929

3030
echo "/target linux (dev-build)"
3131
electronize build /target linux
3232

33-
echo "/target custom win7-x86;win32 (dev-build)"
34-
electronize build /target custom win7-x86;win32
33+
echo "/target custom win7-x86;win (dev-build)"
34+
electronize build /target custom win7-x86;win
3535

3636

3737
:: Be aware, that for non-electronnet-dev environments the correct

0 commit comments

Comments
 (0)