fix planned breaking API changes from Electron 4.0

Author: GregorBiswanger

ElectronNET.API/App.cs

@@ -1029,21 +1029,21 @@ public void SetJumpList(JumpListCategory[] jumpListCategories)
         /// <returns>This method returns false if your process is the primary instance of 
         /// the application and your app should continue loading. And returns true if your 
         /// process has sent its parameters to another instance, and you should immediately quit.</returns>
-        public async Task<bool> MakeSingleInstanceAsync(Action<string[], string> newInstanceOpened, CancellationToken cancellationToken = default(CancellationToken))
+        public async Task<bool> RequestSingleInstanceLockAsync(Action<string[], string> newInstanceOpened, CancellationToken cancellationToken = default(CancellationToken))
         {
             cancellationToken.ThrowIfCancellationRequested();
 
             var taskCompletionSource = new TaskCompletionSource<bool>();
             using (cancellationToken.Register(() => taskCompletionSource.TrySetCanceled()))
             {
-                BridgeConnector.Socket.On("appMakeSingleInstanceCompleted", (success) =>
+                BridgeConnector.Socket.On("appRequestSingleInstanceLockCompleted", (success) =>
                 {
-                    BridgeConnector.Socket.Off("appMakeSingleInstanceCompleted");
+                    BridgeConnector.Socket.Off("appRequestSingleInstanceLockCompleted");
                     taskCompletionSource.SetResult((bool)success);
                 });
 
-                BridgeConnector.Socket.Off("newInstanceOpened");
-                BridgeConnector.Socket.On("newInstanceOpened", (result) =>
+                BridgeConnector.Socket.Off("secondInstance");
+                BridgeConnector.Socket.On("secondInstance", (result) =>
                 {
                     JArray results = (JArray)result;
                     string[] args = results.First.ToObject<string[]>();
@@ -1052,7 +1052,7 @@ public void SetJumpList(JumpListCategory[] jumpListCategories)
                     newInstanceOpened(args, workdirectory);
                 });
 
-                BridgeConnector.Socket.Emit("appMakeSingleInstance");
+                BridgeConnector.Socket.Emit("appRequestSingleInstanceLock");
 
                 return await taskCompletionSource.Task
                     .ConfigureAwait(false);
@@ -1063,9 +1063,9 @@ public void SetJumpList(JumpListCategory[] jumpListCategories)
         /// Releases all locks that were created by makeSingleInstance. This will allow
         /// multiple instances of the application to once again run side by side.
         /// </summary>
-        public void ReleaseSingleInstance()
+        public void ReleaseSingleInstanceLock()
         {
-            BridgeConnector.Socket.Emit("appReleaseSingleInstance");
+            BridgeConnector.Socket.Emit("appReleaseSingleInstanceLock");
         }
 
         /// <summary>
@@ -1155,7 +1155,8 @@ public void SetAppUserModelId(string id)
         /// <summary>
         /// Memory and cpu usage statistics of all the processes associated with the app.
         /// </summary>
-        /// <returns></returns>
+        /// <returns>Array of ProcessMetric objects that correspond to memory and cpu usage
+        /// statistics of all the processes associated with the app.</returns>
         public async Task<ProcessMetric[]> GetAppMetricsAsync(CancellationToken cancellationToken = default(CancellationToken))
         {
             cancellationToken.ThrowIfCancellationRequested();

ElectronNET.API/Entities/HighlightMode.cs

@@ -18,6 +18,16 @@ public enum HighlightMode
         /// <summary>
         /// Never highlight the tray icon.
         /// </summary>
-        never
+        never,
+
+        /// <summary>
+        /// Activate highlight the tray icon.
+        /// </summary>
+        on,
+
+        /// <summary>
+        /// Deactivate highlight the tray icon.
+        /// </summary>
+        off
     }
 }

ElectronNET.API/Entities/WebPreferences.cs

@@ -126,7 +126,7 @@ public class WebPreferences
         /// A list of feature strings separated by ,, like CSSVariables,KeyboardEventKey to
         /// enable.The full list of supported feature strings can be found in the file.
         /// </summary>
-        public string BlinkFeatures { get; set; }
+        public string EnableBlinkFeatures { get; set; }
 
         /// <summary>
         /// A list of feature strings separated by ,, like CSSVariables,KeyboardEventKey to

ElectronNET.CLI/Commands/BuildCommand.cs

@@ -91,7 +91,7 @@ public Task<bool> ExecuteAsync()
                     Console.WriteLine("node_modules missing in: " + checkForNodeModulesDirPath);
 
                     Console.WriteLine("Start npm install...");
-                    ProcessHelper.CmdExecute("npm install", tempPath);
+                    ProcessHelper.CmdExecute("npm install --production", tempPath);
 
                     Console.WriteLine("Start npm install electron-packager...");
 

ElectronNET.Host/.vscode/tasks.json

@@ -1,6 +1,4 @@
 {
-    // See https://go.microsoft.com/fwlink/?LinkId=733558
-    // for the documentation about the tasks.json format
     "version": "2.0.0",
     "tasks": [
         {