Ypatadia/pagination default fix/eng 158360 (#1032)

* fix: removed default value of aria-level in <Dialog/>

* fix: default value to pass to toLocaleString()

* fix: unit test

* fix: changed toLocaleString to pager object

* fix: added length

* fix: added default value to getPageCount

Author: ypatadia-eightfold

src/components/Dialog/BaseDialog/BaseDialog.tsx

@@ -44,7 +44,7 @@ export const BaseDialog: FC<BaseDialogProps> = React.forwardRef(
       headerButtonProps,
       headerClassNames,
       headerIcon = IconName.mdiArrowLeftThick,
-      headingLevel = 1,
+      headingLevel,
       height,
       lastFocusableSelector,
       maskClosable = true,
@@ -154,10 +154,11 @@ export const BaseDialog: FC<BaseDialogProps> = React.forwardRef(
                 <div className={headerClasses}>
                   <span
                     id={labelId}
-                    {...(header && {
-                      role: "heading",
-                      "aria-level": headingLevel
-                    })}
+                    {...(header &&
+                      headingLevel !== undefined && {
+                        role: 'heading',
+                        'aria-level': headingLevel,
+                      })}
                   >
                     {headerButtonProps && (
                       <Button

src/components/Dialog/Dialog.test.tsx

@@ -116,4 +116,68 @@ describe('Dialog', () => {
       false
     );
   });
+
+  test('Should render header without heading attributes when headingLevel is undefined', () => {
+    wrapper.setProps({
+      visible: true,
+      header,
+      body,
+      // headingLevel is undefined by default
+    });
+
+    // Find the header span element
+    const headerSpan = wrapper.find('.header span').first();
+
+    // Should not have role="heading" or aria-level attributes when headingLevel is undefined
+    expect(headerSpan.prop('role')).toBeUndefined();
+    expect(headerSpan.prop('aria-level')).toBeUndefined();
+  });
+
+  test('Should render header with heading attributes when headingLevel is provided', () => {
+    wrapper.setProps({
+      visible: true,
+      header,
+      body,
+      headingLevel: 2,
+    });
+
+    // Find the header span element
+    const headerSpan = wrapper.find('.header span').first();
+
+    // Should have role="heading" and aria-level attributes when headingLevel is provided
+    expect(headerSpan.prop('role')).toBe('heading');
+    expect(headerSpan.prop('aria-level')).toBe(2);
+  });
+
+  test('Should not apply heading attributes when header is not provided even if headingLevel is set', () => {
+    wrapper.setProps({
+      visible: true,
+      // No header prop
+      body,
+      headingLevel: 3,
+    });
+
+    // Find the header span element
+    const headerSpan = wrapper.find('.header span').first();
+
+    // Should not have heading attributes when header prop is not provided
+    expect(headerSpan.prop('role')).toBeUndefined();
+    expect(headerSpan.prop('aria-level')).toBeUndefined();
+  });
+
+  test('Should handle headingLevel of 0 correctly', () => {
+    wrapper.setProps({
+      visible: true,
+      header,
+      body,
+      headingLevel: 0, // Edge case: headingLevel is 0 (falsy but valid)
+    });
+
+    // Find the header span element
+    const headerSpan = wrapper.find('.header span').first();
+
+    // Should still apply heading attributes when headingLevel is 0 (since !== undefined)
+    expect(headerSpan.prop('role')).toBe('heading');
+    expect(headerSpan.prop('aria-level')).toBe(0);
+  });
 });

src/components/Dialog/Dialog.tsx

@@ -42,7 +42,7 @@ export const Dialog: FC<DialogProps> = React.forwardRef(
       headerButtonProps,
       headerClassNames,
       headerIcon,
-      headingLevel=1,
+      headingLevel,
       height,
       locale = enUS,
       okButtonProps,

src/components/Pagination/Pagination.tsx

@@ -247,7 +247,7 @@ export const Pagination: FC<PaginationProps> = React.forwardRef(
     };
 
     const getPageCount = (): number => {
-      let pages: number;
+      let pages: number = 0;
 
       if (total) {
         pages = Math.ceil(total / _pageSize);