Pyright is outdated

[eagleoflqj]

https://open-vsx.org/extension/ms-pyright/pyright the newest is 1.1.239
But https://marketplace.visualstudio.com/items?itemName=ms-pyright.pyright the newest is 1.1.247

[sgtlaggy]

I managed to track down 2 issues here:

• The id is incorrect, it should be ms-pyright.pyright
• The id does not match the values in the manifest, where its name is still vscode-pyright, not just pyright

The first issue is easy enough, just change the id.
The second, however, doesn't appear to be supported. I assume a quick sed/jq on the manifest would not be an acceptable solution.

[filiptronicek]

Hey there @sgtlaggy & @eagleoflqj 👋!

Thanks @eagleoflqj for the report.

Also thanks @sgtlaggy for looking in to this issue, about the ID I have contacted Microsoft to see the purpose or reason for that.

I assume a quick sed/jq on the manifest would not be an acceptable solution.

It would not be ideal, but it could be achieved by using the custom property in the extension definition.

I will look into this further, because from the logs it seems that there's an exception in our publishing code.

[sgtlaggy]

That error in the logs appears to be due to it having the wrong id and not finding it on the VS Marketplace, so the .ms* properties are never set, leading back to the first issue I mentioned.

[sgtlaggy]

Coming back to that error, it can be avoided by changing these lines with the following, allowing the extension to compile just fine.
[process.env.EXTENSION_PUBLISHER, process.env.EXTENSION_NAME] = extension.id.split('.')

This doesn't seem like it should cause any issues with other packages, and may fix some other extensions that failed similarly.
It does remove the requirement(?) that the extension must be present on the MS marketplace, though.

[filiptronicek]

@sgtlaggy thanks for checking, I'm currently working on the fix, so will push to main in a couple of minutes :).

It does remove the requirement(?) that the extension must be present on the MS marketplace, though.

It's good to not require being on MS Marketplace, I would consider it a regression from #565.

[filiptronicek]

@sgtlaggy thanks a lot for the help and for bringing this to my attention once again 🙏.

@eagleoflqj the new version should be now published on Open VSX.

[eagleoflqj]

Thanks both!