Auto merge of rust-lang#8326 - matthiaskrgr:warn_on_multi_configs, r=xFrednet

warn if we find multiple clippy configs

Fixes rust-lang#8323

---

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: warn if we find multiple clippy configs

Author: bors

clippy_lints/src/utils/conf.rs

@@ -322,18 +322,36 @@ pub fn lookup_conf_file() -> io::Result<Option<PathBuf>> {
     let mut current = env::var_os("CLIPPY_CONF_DIR")
         .or_else(|| env::var_os("CARGO_MANIFEST_DIR"))
         .map_or_else(|| PathBuf::from("."), PathBuf::from);
+
+    let mut found_config: Option<PathBuf> = None;
+
     loop {
         for config_file_name in &CONFIG_FILE_NAMES {
             if let Ok(config_file) = current.join(config_file_name).canonicalize() {
                 match fs::metadata(&config_file) {
                     Err(e) if e.kind() == io::ErrorKind::NotFound => {},
                     Err(e) => return Err(e),
                     Ok(md) if md.is_dir() => {},
-                    Ok(_) => return Ok(Some(config_file)),
+                    Ok(_) => {
+                        // warn if we happen to find two config files #8323
+                        if let Some(ref found_config_) = found_config {
+                            eprintln!(
+                                "Using config file `{}`\nWarning: `{}` will be ignored.",
+                                found_config_.display(),
+                                config_file.display(),
+                            );
+                        } else {
+                            found_config = Some(config_file);
+                        }
+                    },
                 }
             }
         }
 
+        if found_config.is_some() {
+            return Ok(found_config);
+        }
+
         // If the current directory has no parent, we're done searching.
         if !current.pop() {
             return Ok(None);

tests/ui-cargo/multiple_config_files/no_warn/Cargo.toml

@@ -0,0 +1,8 @@
+[package]
+name = "no_warn"
+version = "0.1.0"
+edition = "2021"
+
+# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+
+[dependencies]

tests/ui-cargo/multiple_config_files/no_warn/clippy.toml

@@ -0,0 +1 @@
+avoid-breaking-exported-api = false

tests/ui-cargo/multiple_config_files/no_warn/src/main.rs

@@ -0,0 +1,3 @@
+fn main() {
+    println!("Hello, world!");
+}

tests/ui-cargo/multiple_config_files/warn/.clippy.toml

@@ -0,0 +1 @@
+avoid-breaking-exported-api = false

tests/ui-cargo/multiple_config_files/warn/Cargo.toml

@@ -0,0 +1,8 @@
+[package]
+name = "warn"
+version = "0.1.0"
+edition = "2021"
+
+# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+
+[dependencies]

tests/ui-cargo/multiple_config_files/warn/clippy.toml

@@ -0,0 +1 @@
+avoid-breaking-exported-api = false

tests/ui-cargo/multiple_config_files/warn/src/main.rs

@@ -0,0 +1,5 @@
+// ignore-windows
+
+fn main() {
+    println!("Hello, world!");
+}

tests/ui-cargo/multiple_config_files/warn/src/main.stderr

@@ -0,0 +1,2 @@
+Using config file `$SRC_DIR/tests/ui-cargo/multiple_config_files/warn/.clippy.toml`
+Warning: `$SRC_DIR/tests/ui-cargo/multiple_config_files/warn/clippy.toml` will be ignored.