Use Vec instead of SimpleInstructionArgs type

The underlying ArrayVec needs to be boxed anyways,
so there isn't even a performance benefit.

Author: Techcable

src/ast/functions.rs

@@ -1,4 +1,3 @@
-pub use self::args::SimpleInstructionArgs;
 use crate::ast::data::Constant;
 use crate::ast::linkage::Linkage;
 use crate::ast::types::{AbiType, BaseType};
@@ -10,7 +9,6 @@ use std::fmt;
 use std::fmt::{Display, Formatter, Write};
 use std::str::FromStr;
 
-mod args;
 mod parse;
 #[cfg(test)]
 mod test;
@@ -284,7 +282,7 @@ impl_enum_display!(
 pub struct SimpleInstruction {
     pub span: Span,
     pub dest_info: Option<InsnDestInfo>,
-    pub args: SimpleInstructionArgs,
+    pub args: Vec<Value>,
     pub name: Ident,
 }
 impl SimpleInstruction {

src/ast/functions/args.rs

@@ -2,8 +2,8 @@ use crate::ast::data::Constant;
 use crate::ast::functions::{
     CallArgument, CallInstruction, EnvironmentParamDef, FunctionBlock, FunctionBody, FunctionDef,
     InsnDestInfo, JumpInstruction, JumpInstructionKind, ParamDef, PhiArg, PhiInstruction,
-    RegularCallArgument, RegularInstruction, RegularParamDef, SimpleInstruction,
-    SimpleInstructionArgs, ThreadLocalRef, Value, VariadicParamDef,
+    RegularCallArgument, RegularInstruction, RegularParamDef, SimpleInstruction, ThreadLocalRef,
+    Value, VariadicParamDef,
 };
 use crate::ast::linkage::Linkage;
 use crate::ast::types::{AbiType, BaseType};
@@ -284,10 +284,8 @@ impl Parse for SimpleInstruction {
         let values = Value::parser()
             .separated_by(operator!(,).parser())
             .at_least(1)
-            .at_most(SimpleInstructionArgs::LIMIT)
             .allow_trailing()
-            .collect::<Vec<_>>()
-            .map(|values| SimpleInstructionArgs::try_from(&*values).unwrap());
+            .collect::<Vec<_>>();
         InsnDestInfo::parser()
             .or_not()
             .then(Ident::parser())

src/ast/functions/parse.rs

@@ -2,7 +2,7 @@ use crate::ast::data::Constant;
 use crate::ast::functions::{
     CallArgument, CallInstruction, FunctionBlock, FunctionBody, FunctionDef, InsnDestInfo,
     JumpInstruction, ParamDef, PhiArg, PhiInstruction, RegularCallArgument, RegularInstruction,
-    RegularParamDef, SimpleInstruction, SimpleInstructionArgs, Value, VariadicParamDef,
+    RegularParamDef, SimpleInstruction, Value, VariadicParamDef,
 };
 use crate::ast::linkage::Linkage;
 use crate::ast::types::BaseType;
@@ -56,10 +56,7 @@ fn loop_func() -> FunctionDef {
                             dest: TemporaryName::unspanned("x1"),
                             ty: BaseType::Word,
                         }),
-                        args: SimpleInstructionArgs::from([
-                            TemporaryName::unspanned("x").into(),
-                            Value::from(1),
-                        ]),
+                        args: vec![TemporaryName::unspanned("x").into(), Value::from(1)],
                         name: Ident::unspanned("sub"),
                     })],
                     terminator: Some(JumpInstruction::JumpNonZero {
@@ -137,14 +134,14 @@ fn variadic_add3() -> FunctionDef {
                             ty: BaseType::Long,
                             dest: TemporaryName::unspanned("ap"),
                         }),
-                        args: SimpleInstructionArgs::from([32.into()]),
+                        args: vec![32.into()],
                     }
                     .into(),
                     SimpleInstruction {
                         span: Span::MISSING,
                         dest_info: None,
                         name: Ident::unspanned("vastart"),
-                        args: SimpleInstructionArgs::from([TemporaryName::unspanned("ap").into()]),
+                        args: vec![TemporaryName::unspanned("ap").into()],
                     }
                     .into(),
                     CallInstruction {