Skip to content

Adds fix for race condition when reading from cache #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds fix for race condition when reading from cache #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87cddfb
Update fragment.rb
gsdean Jan 11, 2023
a838df6
Merge branch 'DmitryTsepelev:master' into master
gsdean Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/graphql/fragment_cache/fragment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ def read_from_context
end

def value_from_cache
return nil unless FragmentCache.cache_store.exist?(cache_key)

FragmentCache.cache_store.read(cache_key).tap do |cached|
return NIL_IN_CACHE if cached.nil? && FragmentCache.cache_store.exist?(cache_key)
end
Expand Down
Loading