Simplify syntax

Author: DivineOmega

src/SSHConnection.php

@@ -10,6 +10,9 @@
 
 class SSHConnection
 {
+    const FINGERPRINT_MD5 = 'md5';
+    const FINGERPRINT_SHA1 = 'sha1';
+
     private $hostname;
     private $port = 22;
     private $username;
@@ -112,25 +115,21 @@ public function run(string $command): SSHCommand
         return new SSHCommand($this->ssh, $command);
     }
 
-    public function md5Fingerprint(): string
-    {
-        return $this->getFingerprint(0 | 0);
-    }
-
-    public function sha1Fingerprint(): string
-    {
-        return $this->getFingerprint(0 | 0);
-    }
-
-    private function getFingerprint(int $flags)
+    public function fingerprint(string $type = self::FINGERPRINT_MD5)
     {
         if (!$this->connected) {
             throw new RuntimeException('Unable to get fingerprint when not connected.');
         }
 
-        $hostkey = substr($this->ssh->getServerPublicHostKey(), 8);
-        $hostkey = ($flags & 1) ? sha1($hostkey) : md5($hostkey);
-        return ($flags & 2) ? pack('H*', $hostkey) : strtoupper($hostkey);
+        switch ($type) {
+            case 'md5':
+                return strtoupper(md5($hostKey));
+
+            case 'sha1':
+                return strtoupper(sha1($hostKey));
+        }
+
+        throw new InvalidArgumentException('Invalid fingerprint type specified.');
     }
 
     public function upload(string $localPath, string $remotePath): bool

tests/Integration/SSHConnectionTest.php

@@ -89,7 +89,10 @@ public function testMd5Fingerprint()
             ->withPrivateKey('/home/travis/.ssh/id_rsa')
             ->connect();
 
-        $this->assertEquals($connection1->md5Fingerprint(), $connection2->md5Fingerprint());
+        $this->assertEquals(
+            $connection1->fingerprint(SSHConnection::FINGERPRINT_MD5),
+            $connection2->fingerprint(SSHConnection::FINGERPRINT_MD5)
+        );
     }
 
     public function testSha1Fingerprint()
@@ -108,6 +111,9 @@ public function testSha1Fingerprint()
             ->withPrivateKey('/home/travis/.ssh/id_rsa')
             ->connect();
 
-        $this->assertEquals($connection1->sha1Fingerprint(), $connection2->sha1Fingerprint());
+        $this->assertEquals(
+            $connection1->fingerprint(SSHConnection::FINGERPRINT_SHA1),
+            $connection2->fingerprint(SSHConnection::FINGERPRINT_SHA1)
+        );
     }
 }