remove public function "wantToUseJQuery. change hideElement function to private"

Neubert, Sebastian · Neubert, Sebastian · commit 0d7880bb8c86 · 2014-05-22T12:30:29.000+02:00
diff --git a/module/VisualCeption.php b/module/VisualCeption.php
@@ -99,22 +99,12 @@ public function dontSeeVisualChanges ($identifier, $elementID = null, $excludeEl
         }
     }
 
-    /**
-     * Inject jQuery.js to the actual site
-     */
-    public function wantToUseJQuery()
-    {
-        $jQueryString = file_get_contents(__DIR__ . "/jquery.js");
-        $this->webDriver->executeScript($jQueryString);
-        $this->webDriver->executeScript('jQuery.noConflict();');
-    }
-
     /**
      * Hide an element to set the visibility to hidden
      *
      * @param $elementSelector String of jQuery Element selector, set visibility to hidden
      */
-    public function hideElement($elementSelector)
+    private function hideElement($elementSelector)
     {
         $this->webDriver->executeScript('
             if( jQuery("'.$elementSelector.'").length > 0 ) {
@@ -129,7 +119,7 @@ public function hideElement($elementSelector)
      *
      * @param $elementSelector String of jQuery Element selector, set visibility to visible
      */
-    public function showElement($elementSelector)
+    private function showElement($elementSelector)
     {
         $this->webDriver->executeScript('
             if( jQuery("'.$elementSelector.'").length > 0 ) {

Original file line number	Diff line number	Diff line change
`@@ -99,22 +99,12 @@ public function dontSeeVisualChanges ($identifier, $elementID = null, $excludeEl`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`
`102`		`- /**`
`103`		`- * Inject jQuery.js to the actual site`
`104`		`- */`
`105`		`- public function wantToUseJQuery()`
`106`		`- {`
`107`		`- $jQueryString = file_get_contents(__DIR__ . "/jquery.js");`
`108`		`- $this->webDriver->executeScript($jQueryString);`
`109`		`- $this->webDriver->executeScript('jQuery.noConflict();');`
`110`		`- }`
`111`		`-`
`112`	`102`	`/**`
`113`	`103`	`* Hide an element to set the visibility to hidden`
`114`	`104`	`*`
`115`	`105`	`* @param $elementSelector String of jQuery Element selector, set visibility to hidden`
`116`	`106`	`*/`
`117`		`- public function hideElement($elementSelector)`
	`107`	`+ private function hideElement($elementSelector)`
`118`	`108`	`{`
`119`	`109`	`$this->webDriver->executeScript('`
`120`	`110`	`if( jQuery("'.$elementSelector.'").length > 0 ) {`
`@@ -129,7 +119,7 @@ public function hideElement($elementSelector)`
`129`	`119`	`*`
`130`	`120`	`* @param $elementSelector String of jQuery Element selector, set visibility to visible`
`131`	`121`	`*/`
`132`		`- public function showElement($elementSelector)`
	`122`	`+ private function showElement($elementSelector)`
`133`	`123`	`{`
`134`	`124`	`$this->webDriver->executeScript('`
`135`	`125`	`if( jQuery("'.$elementSelector.'").length > 0 ) {`