Added better error handling when creating dirs

Nils Langner · Nils Langner · commit 076533dfc073 · 2014-03-19T23:19:57.000-04:00
diff --git a/module/VisualCeption.php b/module/VisualCeption.php
@@ -117,8 +117,13 @@ private function getScreenshotPath ($identifier)
     {
         $debugDir = \Codeception\Configuration::logDir() . 'debug/tmp/';
         if (! is_dir($debugDir)) {
+            $created = mkdir($debugDir, 0777, true);
+            if( $created ) {
             $this->debug("Creating directory: $debugDir");
-            mkdir($debugDir, 0777, true);
+            }else{
+                throw new \RuntimeException("Unable to create temporary screenshot dir ($debugDir)");
+            }
+
         }
         return $debugDir . $this->getScreenshotName($identifier);
     }

Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,13 @@ private function getScreenshotPath ($identifier)`
`117`	`117`	`{`
`118`	`118`	`$debugDir = \Codeception\Configuration::logDir() . 'debug/tmp/';`
`119`	`119`	`if (! is_dir($debugDir)) {`
	`120`	`+ $created = mkdir($debugDir, 0777, true);`
	`121`	`+ if( $created ) {`
`120`	`122`	`$this->debug("Creating directory: $debugDir");`
`121`		`- mkdir($debugDir, 0777, true);`
	`123`	`+ }else{`
	`124`	`+ throw new \RuntimeException("Unable to create temporary screenshot dir ($debugDir)");`
	`125`	`+ }`
	`126`	`+`
`122`	`127`	`}`
`123`	`128`	`return $debugDir . $this->getScreenshotName($identifier);`
`124`	`129`	`}`