Skip to content

Commit 76a2d14

Browse files
committed
fix static build (examples covered) before PR merge
1 parent eec92e8 commit 76a2d14

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/nbl/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,8 @@ target_compile_definitions(Nabla
422422
INTERFACE _DXC_DLL_NAME_="dxcompiler"
423423
PRIVATE __NBL_BUILDING_NABLA__
424424
)
425-
425+
# OK: im assuming "Nabla" target will be SHARED and we will have separate Nabla-static target in future
426+
# I'm letting it to trigger linker warnings in static build now as I need this generator expressions to propagete to install consumer
426427
target_link_options(Nabla INTERFACE $<$<CXX_COMPILER_FRONTEND_VARIANT:MSVC>:/DELAYLOAD:$<TARGET_FILE_NAME:Nabla::Nabla>>)
427428
if(CMAKE_CXX_COMPILER_FRONTEND_VARIANT MATCHES MSVC)
428429
target_link_options(Nabla
@@ -689,7 +690,7 @@ add_dependencies(Nabla boost_wave)
689690
list(APPEND PUBLIC_BUILD_INCLUDE_DIRS $<TARGET_PROPERTY:boost_wave,INCLUDE_DIRECTORIES>)
690691

691692
if(NBL_STATIC_BUILD)
692-
target_link_libraries(Nabla INTERFACE boost_wave)
693+
target_link_libraries(Nabla PUBLIC boost_wave)
693694
else()
694695
target_link_libraries(Nabla PRIVATE boost_wave)
695696
endif()

0 commit comments

Comments
 (0)