some minor fixes

keptsecret · keptsecret · commit 75b50faa02c0 · 2025-03-04T17:01:16.000+07:00
diff --git a/include/nbl/builtin/hlsl/ieee754.hlsl b/include/nbl/builtin/hlsl/ieee754.hlsl
@@ -148,7 +148,7 @@ NBL_CONSTEXPR_INLINE_FUNC FloatingPoint flipSign(FloatingPoint val, bool flip =
 	using AsFloat = typename float_of_size<sizeof(FloatingPoint)>::type;
 	using AsUint = typename unsigned_integer_of_size<sizeof(FloatingPoint)>::type;
 	const AsUint asUint = ieee754::impl::bitCastToUintType(val);
-	return bit_cast<FloatingPoint>(asUint ^ (flip ? ieee754::traits<AsFloat>::signMask : 0ull));
+	return bit_cast<FloatingPoint>(asUint ^ (flip ? ieee754::traits<AsFloat>::signMask : AsUint(0ull)));
 }
 
 }
diff --git a/include/nbl/builtin/hlsl/tgmath/impl.hlsl b/include/nbl/builtin/hlsl/tgmath/impl.hlsl
@@ -458,7 +458,7 @@ struct erfInv_helper<float64_t>
 	{
 		float64_t x = clamp<float64_t>(_x, NBL_FP64_LITERAL(-0.99999), NBL_FP64_LITERAL(0.99999));
 
-		float64_t w = -log_helper<float64_t>::__call((NBL_FP64_LITERAL(1.0) - x) * (NBL_FP64_LITERAL(1.0) + x));
+		float64_t w = float64_t(-log_helper<float32_t>::__call((float32_t(NBL_FP64_LITERAL(1.0)) - x) * float32_t(NBL_FP64_LITERAL(1.0)) + x));
 		float64_t p;
 		if (w < 6.250000)
 		{

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ NBL_CONSTEXPR_INLINE_FUNC FloatingPoint flipSign(FloatingPoint val, bool flip =`
`148`	`148`	`using AsFloat = typename float_of_size<sizeof(FloatingPoint)>::type;`
`149`	`149`	`using AsUint = typename unsigned_integer_of_size<sizeof(FloatingPoint)>::type;`
`150`	`150`	`const AsUint asUint = ieee754::impl::bitCastToUintType(val);`
`151`		`- return bit_cast<FloatingPoint>(asUint ^ (flip ? ieee754::traits<AsFloat>::signMask : 0ull));`
	`151`	`+ return bit_cast<FloatingPoint>(asUint ^ (flip ? ieee754::traits<AsFloat>::signMask : AsUint(0ull)));`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`}`
Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ struct erfInv_helper<float64_t>`
`458`	`458`	`{`
`459`	`459`	`float64_t x = clamp<float64_t>(_x, NBL_FP64_LITERAL(-0.99999), NBL_FP64_LITERAL(0.99999));`
`460`	`460`
`461`		`- float64_t w = -log_helper<float64_t>::__call((NBL_FP64_LITERAL(1.0) - x) * (NBL_FP64_LITERAL(1.0) + x));`
	`461`	`+ float64_t w = float64_t(-log_helper<float32_t>::__call((float32_t(NBL_FP64_LITERAL(1.0)) - x) * float32_t(NBL_FP64_LITERAL(1.0)) + x));`
`462`	`462`	`float64_t p;`
`463`	`463`	`if (w < 6.250000)`
`464`	`464`	`{`